Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-21 Thread Ferruh Yigit
On 11/21/2017 6:04 AM, Pavan Nikhilesh Bhagavatula wrote: > On Tue, Nov 21, 2017 at 02:30:48PM +0100, Thomas Monjalon wrote: >> 21/11/2017 12:14, Pavan Nikhilesh Bhagavatula: >>> On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote: 20/11/2017 19:40, Ferruh Yigit: > >>> >>> I will

Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-21 Thread Pavan Nikhilesh Bhagavatula
On Tue, Nov 21, 2017 at 02:30:48PM +0100, Thomas Monjalon wrote: > 21/11/2017 12:14, Pavan Nikhilesh Bhagavatula: > > On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote: > > > 20/11/2017 19:40, Ferruh Yigit: > > > > I will be sending out the patch set soon. > > These are only the lega

Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-21 Thread Thomas Monjalon
21/11/2017 12:14, Pavan Nikhilesh Bhagavatula: > On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote: > > 20/11/2017 19:40, Ferruh Yigit: > > > And, since you are touching these files :), > > > for better regex support, it may be good to have log types hierarchical, > > > like > > > "l

Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-21 Thread Pavan Nikhilesh Bhagavatula
On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote: > 20/11/2017 19:40, Ferruh Yigit: > > And, since you are touching these files :), > > for better regex support, it may be good to have log types hierarchical, > > like > > "lib.mbuf", "lib.mempool", "lib.eal.malloc", as done in membe

Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-21 Thread Thomas Monjalon
20/11/2017 19:40, Ferruh Yigit: > And, since you are touching these files :), > for better regex support, it may be good to have log types hierarchical, like > "lib.mbuf", "lib.mempool", "lib.eal.malloc", as done in member library but > with > "lib" prefix instead of "librte", if this makes sense

Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-21 Thread Pavan Nikhilesh Bhagavatula
On Mon, Nov 20, 2017 at 10:40:29AM -0800, Ferruh Yigit wrote: > On 11/17/2017 12:47 AM, Pavan Nikhilesh Bhagavatula wrote: > > On Thu, Nov 16, 2017 at 11:48:14AM -0800, Ferruh Yigit wrote: > >> On 11/16/2017 2:31 AM, Pavan Nikhilesh wrote: > >>> Dynamic logs fail to print if the global log level is

Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-20 Thread Ferruh Yigit
On 11/17/2017 12:47 AM, Pavan Nikhilesh Bhagavatula wrote: > On Thu, Nov 16, 2017 at 11:48:14AM -0800, Ferruh Yigit wrote: >> On 11/16/2017 2:31 AM, Pavan Nikhilesh wrote: >>> Dynamic logs fail to print if the global log level is less than dynamic >>> loglevel. Example if the global log level is se

Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-17 Thread Pavan Nikhilesh Bhagavatula
On Thu, Nov 16, 2017 at 11:48:14AM -0800, Ferruh Yigit wrote: > On 11/16/2017 2:31 AM, Pavan Nikhilesh wrote: > > Dynamic logs fail to print if the global log level is less than dynamic > > loglevel. Example if the global log level is set to INFO and dynamic log > > level for a specific module is s

Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-16 Thread Ferruh Yigit
On 11/16/2017 2:31 AM, Pavan Nikhilesh wrote: > Dynamic logs fail to print if the global log level is less than dynamic > loglevel. Example if the global log level is set to INFO and dynamic log > level for a specific module is set to DEBUG then the log fails to print. What is the purpose of the g