Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix hot-unplug detaching

2020-02-17 Thread Kevin Traynor
On 16/02/2020 09:47, Thomas Monjalon wrote: > 16/02/2020 09:09, Matan Azrad: >> Hi Thomas >> >> Thanks for the patches, I Saw it just now. >> please see small comment below: >> >> From: Thomas Monjalon >>> There is a possible race condition in the hotplug path in >>> rmv_port_callback(). >>> If

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix hot-unplug detaching

2020-02-16 Thread Thomas Monjalon
16/02/2020 09:09, Matan Azrad: > Hi Thomas > > Thanks for the patches, I Saw it just now. > please see small comment below: > > From: Thomas Monjalon > > There is a possible race condition in the hotplug path in > > rmv_port_callback(). > > If a port is created between > > close_port(port_id)

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix hot-unplug detaching

2020-02-16 Thread Matan Azrad
Hi Thomas Thanks for the patches, I Saw it just now. please see small comment below: From: Thomas Monjalon > There is a possible race condition in the hotplug path in rmv_port_callback(). > If a port is created between > close_port(port_id) and detach_port_device(port_id), then the port_id will