Re: [dpdk-dev] [PATCH 10/11] net/failsafe: fix sub-device ownership race

2018-05-09 Thread Gaëtan Rivet
On Wed, May 09, 2018 at 03:43:31PM +0200, Thomas Monjalon wrote: > 09/05/2018 15:30, Gaëtan Rivet: > > On Wed, May 09, 2018 at 01:01:58PM +, Matan Azrad wrote: > > > Regarding uint32 > > > The maximum port id number can be 0x. > > > In this case the loop will be infinite if we use uint16 to

Re: [dpdk-dev] [PATCH 10/11] net/failsafe: fix sub-device ownership race

2018-05-09 Thread Thomas Monjalon
09/05/2018 15:30, Gaëtan Rivet: > On Wed, May 09, 2018 at 01:01:58PM +, Matan Azrad wrote: > > Hi Gaetan > > > > Regarding backporting. > > This version should be bacported for 18.02.1. > > There we have the new event. > > > > Then the fixline should probably reflect this instead. > Targetti

Re: [dpdk-dev] [PATCH 10/11] net/failsafe: fix sub-device ownership race

2018-05-09 Thread Gaëtan Rivet
On Wed, May 09, 2018 at 01:01:58PM +, Matan Azrad wrote: > Hi Gaetan > > Regarding backporting. > This version should be bacported for 18.02.1. > There we have the new event. > Then the fixline should probably reflect this instead. Targetting the initial failsafe release won't work. This pa

Re: [dpdk-dev] [PATCH 10/11] net/failsafe: fix sub-device ownership race

2018-05-09 Thread Thomas Monjalon
09/05/2018 14:41, Gaëtan Rivet: > > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") > > This fix is relying on the RTE_ETH_EVENT_NEW, an API that I think is not > meant to be backported in the stable release that would be targetted by > this commit id. This event was added in 18.02. So ye

Re: [dpdk-dev] [PATCH 10/11] net/failsafe: fix sub-device ownership race

2018-05-09 Thread Matan Azrad
Hi Gaetan Regarding backporting. This version should be bacported for 18.02.1. There we have the new event. Regarding uint32 The maximum port id number can be 0x. In this case the loop will be infinite if we use uint16 to iterate over all the ports. Hello Matan, Two nitpicks below: On Wed,

Re: [dpdk-dev] [PATCH 10/11] net/failsafe: fix sub-device ownership race

2018-05-09 Thread Gaëtan Rivet
Hello Matan, Two nitpicks below: On Wed, May 09, 2018 at 11:43:36AM +0200, Thomas Monjalon wrote: > From: Matan Azrad > > There is time between the sub-device port probing by the sub-device PMD > to the sub-device port ownership taking by a fail-safe port. > > In this time, the port is availab