Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-24 Thread george . dit
Hi again, I decided to simplify things for now, hence sent a new minimal patch only for testpmd (not librte_cmdline), which allows external applications to compile against it without errors. Thanks again for you time, Georgios On Tue, Jan 16, 2018 at 6:54 PM, Adrien Mazarguil wrote: > On Tue, J

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-16 Thread Adrien Mazarguil
On Tue, Jan 16, 2018 at 03:54:57PM +0100, george@gmail.com wrote: > Hi Adrien, > > Thanks for your insights and sorry for omitting the cover letter (this is > my first patch in DPDK). No problem, don't worry about that. Remember to put as much context as close as possible to the related chang

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-16 Thread george . dit
Hi Adrien, Thanks for your insights and sorry for omitting the cover letter (this is my first patch in DPDK). I understand your concerns. The reason I proposed this patch is to facilitate a more high level vendor agnostic API for configuring and monitoring DPDK-based NICs. To avoid just copying t

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-16 Thread Adrien Mazarguil
George, I missed the original RFC thread [1][2] (you should have used it as a cover letter for this series BTW) please see below. On Tue, Jan 16, 2018 at 10:24:25AM +0100, Olivier Matz wrote: > Hi, > > > On Tue, Jan 16, 2018 at 9:40 AM Olivier Matz wrote: > > > > On Tue, Jan 16, 2018 at 08:45:3

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-16 Thread Gaƫtan Rivet
Hi Olivier, George, thanks for following up on that, On Tue, Jan 16, 2018 at 10:24:25AM +0100, Olivier Matz wrote: > Hi, > > > On Tue, Jan 16, 2018 at 9:40 AM Olivier Matz wrote: > > > > On Tue, Jan 16, 2018 at 08:45:32AM +, george@gmail.com wrote: > > > Hi Georgios, > > > > > > On Mon,

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-16 Thread Olivier Matz
Hi, > On Tue, Jan 16, 2018 at 9:40 AM Olivier Matz wrote: > > On Tue, Jan 16, 2018 at 08:45:32AM +, george@gmail.com wrote: > > Hi Georgios, > > > > On Mon, Jan 15, 2018 at 01:30:35AM +, Lu, Wenzhuo wrote: > > > Hi, > > > > > > > -Original Message- > > > > From: dev [mailto:de

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-16 Thread george . dit
Hi Lu, Oliver, Thanks for your feedback! You have a point here, flow commands are only a subset of the parser. Do you want me to create this new library and send another patch? I guess I have to use librte_cmdline as a template/example for creating the librte_flow_cmdline library. Best regards, G

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-16 Thread Olivier Matz
Hi Georgios, On Mon, Jan 15, 2018 at 01:30:35AM +, Lu, Wenzhuo wrote: > Hi, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Georgios Katsikas > > Sent: Saturday, January 13, 2018 5:01 AM > > To: olivier.m...@6wind.com > > Cc: dev@dpdk.org; Georgios Ka

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-14 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Georgios Katsikas > Sent: Saturday, January 13, 2018 5:01 AM > To: olivier.m...@6wind.com > Cc: dev@dpdk.org; Georgios Katsikas > Subject: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to > librte_cmd