Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling

2019-09-30 Thread Maxime Coquelin
On 6/19/19 8:13 AM, Noa Ezra wrote: > TSO (TCP Segmentation Offload) is enabled by default on vhost. > Add the ability to disable TSO on vhost. > The user should also disable the feature on the virtual machine's xml. > > Signed-off-by: Noa Ezra > Reviewed-by: Matan Azrad > --- > doc/guides/n

Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling

2019-08-30 Thread Maxime Coquelin
On 6/19/19 8:13 AM, Noa Ezra wrote: > TSO (TCP Segmentation Offload) is enabled by default on vhost. > Add the ability to disable TSO on vhost. > The user should also disable the feature on the virtual machine's xml. > > Signed-off-by: Noa Ezra > Reviewed-by: Matan Azrad > --- > doc/guides/n

Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling

2019-06-20 Thread Maxime Coquelin
On 6/20/19 8:08 AM, Matan Azrad wrote: Hi Tiwei, Maxim From: Tiwei Bie Sent: Thursday, June 20, 2019 5:26 AM To: Maxime Coquelin Cc: Noa Ezra ; Matan Azrad ; dev@dpdk.org Subject: Re: [PATCH 1/2] net/vhost: support TSO disabling On Wed, Jun 19, 2019 at 11:53:05AM +0200, Maxime Coquelin wr

Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling

2019-06-19 Thread Matan Azrad
Hi Tiwei, Maxim From: Tiwei Bie > Sent: Thursday, June 20, 2019 5:26 AM > To: Maxime Coquelin > Cc: Noa Ezra ; Matan Azrad ; > dev@dpdk.org > Subject: Re: [PATCH 1/2] net/vhost: support TSO disabling > > On Wed, Jun 19, 2019 at 11:53:05AM +0200, Maxime Coquelin wrote: > > On 6/19/19 8:13 AM, N

Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling

2019-06-19 Thread Tiwei Bie
On Wed, Jun 19, 2019 at 11:53:05AM +0200, Maxime Coquelin wrote: > On 6/19/19 8:13 AM, Noa Ezra wrote: > > TSO (TCP Segmentation Offload) is enabled by default on vhost. > > Add the ability to disable TSO on vhost. > > The user should also disable the feature on the virtual machine's xml. > > For

Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling

2019-06-19 Thread Maxime Coquelin
On 6/19/19 8:13 AM, Noa Ezra wrote: TSO (TCP Segmentation Offload) is enabled by default on vhost. Add the ability to disable TSO on vhost. The user should also disable the feature on the virtual machine's xml. For TSO, I think it make sense to have the option to disable it, as it requires t