Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel divergence

2017-02-27 Thread Lu, Wenzhuo
Hi Vincent, > -Original Message- > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > Sent: Friday, February 24, 2017 5:14 PM > To: Lu, Wenzhuo; Stephen Hemminger > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel > div

Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel divergence

2017-02-24 Thread Vincent JARDIN
Le 24/02/2017 à 08:23, Lu, Wenzhuo a écrit : It is good to allow setting QoS on device, but it looks like this is a device specific API, not a generic PMD function. I don't think any feature in DPDK should be hardcoded to one device type. Yes, they're private APIs. Normally we want to support ke