Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-20 Thread Ferruh Yigit
On 9/20/2018 7:37 AM, Yogev Chaimovich wrote: > 'stats_reset()' callback was missing because the device backend doesn’t > support it. > This commit adds a workaround to this and implements the callback by taking a > snapshot of the stats (SNAPSHOT) each time 'stats_reset()' is called. > When gett

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-20 Thread Yong Wang
-Original Message- From: dev on behalf of Yogev Chaimovich Date: Wednesday, September 19, 2018 at 11:37 PM To: "dev@dpdk.org" Cc: Yogev Chaimovich Subject: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation 'stats_reset()' callback was missing because the device backend doesn’

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-19 Thread Yogev Chaimovich
I'll add it. Actually I didn't know why it wasn't implemented. Thanks. -Original Message- From: Yong Wang Sent: Monday, September 17, 2018 8:21 PM To: Yogev Chaimovich Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation > On Sep 17,

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-17 Thread Yong Wang
> On Sep 17, 2018, at 12:45 AM, yogev ch wrote: > > 'stats_reset()' callback was missing. > This commit implements the callback by taking a snapshot of the stats > (SNAPSHOT) each time 'stats_reset()' is called. > When getting stats with 'stats_get()', hw stats which always increase reduce >

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-16 Thread Yogev Chaimovich
No problem. I wrote this description - I hope it's understandable. I also attached the new commit to this mail. " 'stats_reset()' callback was missing. This commit implements the callback by taking a snapshot of the stats (SNAPSHOT) each time 'stats_reset()' is called. When getting stats with 'st

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-13 Thread Yong Wang
-Original Message- From: yogev ch Date: Wednesday, August 22, 2018 at 12:38 AM To: Yong Wang Cc: "dev@dpdk.org" , "yo...@cgstowernetworks.com" Subject: [PATCH] vmxnet3: stats_reset implementation Signed-off-by: yogev ch --- Yogev, The change looks fine to me. Can you add a