Re: [dpdk-dev] [PATCH] vhost: fix external mbuf creation

2020-10-09 Thread yang_y_yi
Thanks Oliver for posting this patch, it clearly explain his concern, I totally agree this change. I tested it by OVS DPDK, it works well. At 2020-10-07 20:53:18, "Olivier Matz" wrote: >In virtio_dev_extbuf_alloc(), the shinfo structure used to store >the reference counter and the free callback

Re: [dpdk-dev] [PATCH] vhost: fix external mbuf creation

2020-10-09 Thread yang_y_yi
Tested-by: Yi Yang At 2020-10-07 20:53:18, "Olivier Matz" wrote: >In virtio_dev_extbuf_alloc(), the shinfo structure used to store >the reference counter and the free callback of the external buffer >is by default stored inside the mbuf data. > >This is wrong because the mbuf

Re: [dpdk-dev] [PATCH] vhost: fix external mbuf creation

2020-10-09 Thread Maxime Coquelin
On 10/7/20 2:53 PM, Olivier Matz wrote: > In virtio_dev_extbuf_alloc(), the shinfo structure used to store > the reference counter and the free callback of the external buffer > is by default stored inside the mbuf data. > > This is wrong because the mbuf (and its data) can be freed before > th

Re: [dpdk-dev] [PATCH] vhost: fix external mbuf creation

2020-10-09 Thread Maxime Coquelin
On 10/7/20 2:53 PM, Olivier Matz wrote: > In virtio_dev_extbuf_alloc(), the shinfo structure used to store > the reference counter and the free callback of the external buffer > is by default stored inside the mbuf data. > > This is wrong because the mbuf (and its data) can be freed before > th