Hi Alejandro,
>Those lines are not error messages. Are you suggesting not splitting lines in
>the commit comment?
Apologies, that (and other instances) was supposed to mean "snipped" :)
> What do you refer to? The TODO line?
No, I was referring to "map BARS" comment in an unmapping function.
On Thu, Mar 23, 2017 at 12:08 PM, Burakov, Anatoly <
anatoly.bura...@intel.com> wrote:
> Hi Alejandro,
>
> I think the documentation should also be updated to reflect the fact that
> this patch adds VFIO support for hotplug.
>
Yes. Thanks.
I will submit a new version with all the fixes from your
Hi Anatoly,
On Wed, Mar 22, 2017 at 1:49 PM, Burakov, Anatoly wrote:
> Hi Alejandro,
>
> Just a general comment, I think there's now a rule to not split error
> messages onto multiple lines
> even if going above the 80 char limit, to make grepping easier.
>
>
Ok. Thanks.
> > Current device hot
Hi Alejandro,
I think the documentation should also be updated to reflect the fact that this
patch adds VFIO support for hotplug.
Thanks,
Anatoly
Hi Alejandro,
Just a general comment, I think there's now a rule to not split error messages
onto multiple lines
even if going above the 80 char limit, to make grepping easier.
> Current device hotplug is just when using UIO. This patch adds
> same functionality with VFIO.
>
> It has been valid
On 16/03/17 11:51, Alejandro Lucero wrote:
Current device hotplug is just when using UIO. This patch adds
same functionality with VFIO.
It has been validated through tests using IOMMU and also with VFIO
and no-iommu mode.
Signed-off-by: Alejandro Lucero
---
lib/librte_eal/common/eal_common_p
6 matches
Mail list logo
