Re: [dpdk-dev] [PATCH] net/pcap: support hardware Tx timestamps

2020-06-30 Thread Vivien Didelot
Hi Olivier, On Thu, 25 Jun 2020 18:35:32 +0200, Olivier Matz wrote: > As said by Ferruh, the unit of timestamp in mbuf is not normalized to > nanosecs, as seen in rte_mbuf_core.h: > > /** Valid if PKT_RX_TIMESTAMP is set. The unit and time reference >* are not normalized but are al

Re: [dpdk-dev] [PATCH] net/pcap: support hardware Tx timestamps

2020-06-26 Thread Ferruh Yigit
On 6/25/2020 7:49 PM, Vivien Didelot wrote: > Hi Olivier, > > On Thu, 25 Jun 2020 18:35:32 +0200, Olivier Matz > wrote: >> As said by Ferruh, the unit of timestamp in mbuf is not normalized to >> nanosecs, as seen in rte_mbuf_core.h: >> >> /** Valid if PKT_RX_TIMESTAMP is set. The unit and

Re: [dpdk-dev] [PATCH] net/pcap: support hardware Tx timestamps

2020-06-25 Thread Olivier Matz
Hi Vivien, On Tue, Jun 23, 2020 at 06:10:09PM -0400, Vivien Didelot wrote: > > On Wed, Jun 17, 2020 at 4:16 AM Ferruh Yigit wrote: > > > On 6/10/2020 8:39 PM, Vivien Didelot wrote: > > > When hardware timestamping is enabled on Rx path, system time should > > > no longer be used to calculate th

Re: [dpdk-dev] [PATCH] net/pcap: support hardware Tx timestamps

2020-06-25 Thread Vivien Didelot
Hi Oliver, Surprisingly, dumping PCAP with hardware timestamps seems to be a niche, but we do need this feature for our network analyzing tool. Do you guys have objections for this patch? Regards, Vivien On Wed, Jun 17, 2020 at 4:16 AM Ferruh Yigit wrote: > On 6/10/2020 8:39 PM, Vivien Didel

Re: [dpdk-dev] [PATCH] net/pcap: support hardware Tx timestamps

2020-06-17 Thread Vivien Didelot
Hi Ferruh, On Wed, 10 Jun 2020 15:39:38 -0400, Vivien Didelot wrote: > When hardware timestamping is enabled on Rx path, system time should > no longer be used to calculate the timestamps when dumping packets. > > Instead, use the value stored by the driver in mbuf->timestamp > and assume it is

Re: [dpdk-dev] [PATCH] net/pcap: support hardware Tx timestamps

2020-06-17 Thread Ferruh Yigit
On 6/10/2020 8:39 PM, Vivien Didelot wrote: > When hardware timestamping is enabled on Rx path, system time should > no longer be used to calculate the timestamps when dumping packets. > > Instead, use the value stored by the driver in mbuf->timestamp > and assume it is already converted to nanose