Re: [dpdk-dev] [PATCH] net/mlx5: support extended statistics

Please ignore, forgot to add v4 to subject. Tuesday, January 17, 2017 4:29 PM, Shahaf Shuler: > > Implement extended statistics callbacks. > > Suggested-by: Hanoch Haim > Signed-off-by: Shahaf Shuler > Signed-off-by: Elad Persiko > Acked-by: Adrien Mazarguil > --- > on v4: > * fix compilat

Re: [dpdk-dev] [PATCH] net/mlx5: support extended statistics

Hi Shahaf, I am not specifically interested in this thread, but if I was, it is not sure I would make the effort to try to understand your message (starting with a signature, an useless original header, and some long useless listings). I won't try to find which special sign you use to mark your re

Re: [dpdk-dev] [PATCH] net/mlx5: support extended statistics

--Shahaf -Original Message- From: Hanoch Haim (hhaim) [mailto:hh...@cisco.com] Sent: Thursday, January 12, 2017 11:57 AM To: Adrien Mazarguil ; Shahaf Shuler Cc: dev@dpdk.org; Elad Persiko Subject: RE: [PATCH] net/mlx5: support extended statistics Hi Shahaf, 1) I would add *all* t

Re: [dpdk-dev] [PATCH] net/mlx5: support extended statistics

Hi Shahaf, 1) I would add *all* the hw counters to PF $ethtool -S enp135s0f0 NIC statistics: rx_packets: 54 rx_bytes: 3240 tx_packets: 138 tx_bytes: 8280 tx_tso_packets: 0 tx_tso_bytes: 0 tx_tso_inner_packets: 0 tx_tso_inner_bytes: 0 rx_lro_packets: 0

Re: [dpdk-dev] [PATCH] net/mlx5: support extended statistics

Hi Shahaf, Thanks, I have a few comments, most of them relatively minor. Please see below. On Wed, Jan 11, 2017 at 10:55:42AM +0200, Shahaf Shuler wrote: > Implement xstats_*() DPDK callbacks > > Signed-off-by: Shahaf Shuler > Signed-off-by: Elad Persiko > Signed-off-by: Hanoch Haim > --- >