Re: [dpdk-dev] [PATCH] net/mlx5: fix calculating TSO inline size

2017-09-13 Thread Nélio Laranjeiro
On Wed, Sep 13, 2017 at 05:05:14AM +, Shahaf Shuler wrote: > Tuesday, September 12, 2017 9:34 PM, Nélio Laranjeiro: > > > On Sep 12, 2017, at 12:24 AM, Nélio Laranjeiro > > >>> Is not it dangerous to assume inl will always be 4 bytes long? Why > > >>> not writing the real value instead? > > >>

Re: [dpdk-dev] [PATCH] net/mlx5: fix calculating TSO inline size

2017-09-12 Thread Shahaf Shuler
Tuesday, September 12, 2017 9:34 PM, Nélio Laranjeiro: > > On Sep 12, 2017, at 12:24 AM, Nélio Laranjeiro > >>> Is not it dangerous to assume inl will always be 4 bytes long? Why > >>> not writing the real value instead? > >> That was for readability of the code and uint32_t will be always > >> 4b

Re: [dpdk-dev] [PATCH] net/mlx5: fix calculating TSO inline size

2017-09-12 Thread Yongseok Koh
> On Sep 12, 2017, at 12:24 AM, Nélio Laranjeiro > wrote: > > On Mon, Sep 11, 2017 at 03:17:44PM -0700, Yongseok Koh wrote: >> On Mon, Sep 04, 2017 at 04:01:08PM +0200, Nélio Laranjeiro wrote: >>> Hi Yongseok, >>> >>> Please see some comments below, >>> >>> On Thu, Aug 31, 2017 at 09:27:06AM

Re: [dpdk-dev] [PATCH] net/mlx5: fix calculating TSO inline size

2017-09-12 Thread Nélio Laranjeiro
On Mon, Sep 11, 2017 at 03:17:44PM -0700, Yongseok Koh wrote: > On Mon, Sep 04, 2017 at 04:01:08PM +0200, Nélio Laranjeiro wrote: > > Hi Yongseok, > > > > Please see some comments below, > > > > On Thu, Aug 31, 2017 at 09:27:06AM -0700, Yongseok Koh wrote: > > > Tx descriptor for TSO embeds packe

Re: [dpdk-dev] [PATCH] net/mlx5: fix calculating TSO inline size

2017-09-11 Thread Yongseok Koh
On Mon, Sep 04, 2017 at 04:01:08PM +0200, Nélio Laranjeiro wrote: > Hi Yongseok, > > Please see some comments below, > > On Thu, Aug 31, 2017 at 09:27:06AM -0700, Yongseok Koh wrote: > > Tx descriptor for TSO embeds packet header to be replicated. If Tx inline > > is enabled, there could be addit

Re: [dpdk-dev] [PATCH] net/mlx5: fix calculating TSO inline size

2017-09-04 Thread Nélio Laranjeiro
Hi Yongseok, Please see some comments below, On Thu, Aug 31, 2017 at 09:27:06AM -0700, Yongseok Koh wrote: > Tx descriptor for TSO embeds packet header to be replicated. If Tx inline > is enabled, there could be additional packet data inlined with 4B inline > header ahead. And between the header