Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance

2017-02-10 Thread Yang, Qiming
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, February 10, 2017 6:25 PM > To: Yang, Qiming ; dev@dpdk.org > Cc: Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance > > On 2/10/2017 1:26 AM, Qiming Yang wrote

Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance

2017-02-10 Thread Ferruh Yigit
On 2/10/2017 1:26 AM, Qiming Yang wrote: > This patch removed useless tx_flags in vlan insertion. Overall this looks good, I wonder what was the initial intention of this code, understanding it helps to figure out if there is a hidden defect. This code not fixes a defect, but improves the code, i