Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-10-17 Thread Olivier Matz
Hi Konstantin, On Thu, Oct 17, 2019 at 11:58:52AM +, Ananyev, Konstantin wrote: > > Hi Olivier, > > > > > Many features require to store data inside the mbuf. As the room in mbuf > > > > structure is limited, it is not possible to have a field for each > > > > feature. Also, changing fields

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-10-17 Thread Ananyev, Konstantin
Hi Olivier, > > > Many features require to store data inside the mbuf. As the room in mbuf > > > structure is limited, it is not possible to have a field for each > > > feature. Also, changing fields in the mbuf structure can break the API > > > or ABI. > > > > > > This commit addresses these is

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-10-17 Thread Olivier Matz
Hi Konstantin, Thanks for the feedback. Please see my answers below. On Tue, Oct 01, 2019 at 10:49:39AM +, Ananyev, Konstantin wrote: > Hi Olivier, > > > Many features require to store data inside the mbuf. As the room in mbuf > > structure is limited, it is not possible to have a field for

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-10-01 Thread Ananyev, Konstantin
Hi Olivier, > Many features require to store data inside the mbuf. As the room in mbuf > structure is limited, it is not possible to have a field for each > feature. Also, changing fields in the mbuf structure can break the API > or ABI. > > This commit addresses these issues, by enabling the dyn

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wiles, Keith
> On Sep 23, 2019, at 11:16 AM, Olivier Matz wrote: > > Hi, > > (reformated the quotes) > > On Mon, Sep 23, 2019 at 03:14:51PM +, Wiles, Keith wrote: >> >> >> On Sep 23, 2019, at 4:13 AM, Olivier Matz >> mailto:olivier.m...@6wind.com>> wrote: >>> >>> Hi Keith, >>> >>> On Sat, Sep 21,

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Olivier Matz
Hi, (reformated the quotes) On Mon, Sep 23, 2019 at 03:14:51PM +, Wiles, Keith wrote: > > > On Sep 23, 2019, at 4:13 AM, Olivier Matz > mailto:olivier.m...@6wind.com>> wrote: > > > > Hi Keith, > > > > On Sat, Sep 21, 2019 at 08:28:32AM +, Wiles, Keith wrote: > > > > > > > > > On Se

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wiles, Keith
Sorry, resend in plain text :-( > On Sep 23, 2019, at 4:13 AM, Olivier Matz wrote: > > Hi Keith, > > On Sat, Sep 21, 2019 at 08:28:32AM +, Wiles, Keith wrote: >> >> >>> On Sep 18, 2019, at 6:54 PM, Olivier Matz wrote: >>> >>> Many features require to store data inside the mbuf. As the r

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wiles, Keith
On Sep 23, 2019, at 4:13 AM, Olivier Matz mailto:olivier.m...@6wind.com>> wrote: Hi Keith, On Sat, Sep 21, 2019 at 08:28:32AM +, Wiles, Keith wrote: On Sep 18, 2019, at 6:54 PM, Olivier Matz mailto:olivier.m...@6wind.com>> wrote: Many features require to store data inside the mbuf. As

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wang, Haiyue
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, September 23, 2019 16:32 > To: Wang, Haiyue > Cc: dev@dpdk.org; Thomas Monjalon ; Stephen Hemminger > ; Andrew Rybchenko ; > Wiles, Keith > ; Jerin Jacob Kollanukkaran > Subject: Re: [PATCH] mbuf: s

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Olivier Matz
Hi Morten, On Mon, Sep 23, 2019 at 10:56:01AM +0200, Morten Brørup wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith > > Sent: Saturday, September 21, 2019 10:29 AM > > > > > On Sep 18, 2019, at 6:54 PM, Olivier Matz > > wrote: > > > > >

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Olivier Matz
Hi Keith, On Sat, Sep 21, 2019 at 08:28:32AM +, Wiles, Keith wrote: > > > > On Sep 18, 2019, at 6:54 PM, Olivier Matz wrote: > > > > Many features require to store data inside the mbuf. As the room in mbuf > > structure is limited, it is not possible to have a field for each > > feature. A

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith > Sent: Saturday, September 21, 2019 10:29 AM > > > On Sep 18, 2019, at 6:54 PM, Olivier Matz > wrote: > > > > Many features require to store data inside the mbuf. As the room in > mbuf > > structure

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Olivier Matz
Hi, On Sat, Sep 21, 2019 at 04:54:39AM +, Wang, Haiyue wrote: > > -Original Message- > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Thursday, September 19, 2019 00:55 > > To: dev@dpdk.org > > Cc: Thomas Monjalon ; Wang, Haiyue > > ; Stephen Hemminger > > ; Andrew Ryb

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-21 Thread Wiles, Keith
> On Sep 18, 2019, at 6:54 PM, Olivier Matz wrote: > > Many features require to store data inside the mbuf. As the room in mbuf > structure is limited, it is not possible to have a field for each > feature. Also, changing fields in the mbuf structure can break the API > or ABI. > > This commit

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-20 Thread Wang, Haiyue
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Thursday, September 19, 2019 00:55 > To: dev@dpdk.org > Cc: Thomas Monjalon ; Wang, Haiyue > ; Stephen Hemminger > ; Andrew Rybchenko ; > Wiles, Keith > ; Jerin Jacob Kollanukkaran > Subject: [PATCH] mbuf: