Re: [dpdk-dev] [PATCH] ip_frag: modify the fragment offset and mf

2021-10-08 Thread Ananyev, Konstantin
From: 蔡慧超 Sent: Friday, October 8, 2021 10:38 AM To: Ananyev, Konstantin Cc: cai...@chinatelecom.cn; dev@dpdk.org Subject: Re:RE: Re:RE: [PATCH] ip_frag: modify the fragment offset and mf Hi Konstantin, Thank you for your reply, it's so useful!!! But I have some questions. Would you mind an

Re: [dpdk-dev] [PATCH] ip_frag: modify the fragment offset and mf

2021-10-08 Thread 蔡慧超
Hi Konstantin, Thank you for your reply, it's so useful!!! But I have some questions. Would you mind answer my questions? >Cc: mailto:sta...@dpdk.org This should be written in the commiter message:Cc: sta...@dpdk.org,right? When I send patch,what is the parameters of --subject-prefix?(Which bra

Re: [dpdk-dev] [PATCH] ip_frag: modify the fragment offset and mf

2021-10-08 Thread Ananyev, Konstantin
Hi Kevin, I thought about something like that (feel free to update it if you feel I missed something): ip_frag: fix fragmenting IPv4 fragment Current implementation of rte_ipv4_fragment_packet() doesn’t take into account offset and flag values of the given packet, but blindly assumes they are al

Re: [dpdk-dev] [PATCH] ip_frag: modify the fragment offset and mf

2021-10-08 Thread 蔡慧超
Hi,Ananyev, Konstantin Thank you for your reply.I'm sorry for my poor English.This is the first time I've submitted a patch to the DPDK, and some of the processes are not familiar.I am happy to contribute to the DPDK. As described in your message: >As I understand what that patch does - fix

Re: [dpdk-dev] [PATCH] ip_frag: modify the fragment offset and mf

2021-10-07 Thread Ananyev, Konstantin
> From: huichao cai > > According to RFC791,the fragment offset value should be > calculated based on the long datagram,the more fragments flag > for the last fragment carries the same value as the long datagram. Have to admit, that commit log is really cryptic. I couldn't figure out what it