Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

Hi Kirill, On Tue, Jan 16, 2018 at 05:23:05PM +, Rybalchenko, Kirill wrote: > Hi Adrien, > after some discussion we found that change I've done > in Mellanox PMD is not really necessary: size of array > flow_types_mask[] is still 1 and the loop in patch > > for (i = 0; i < RTE_FLOW_MASK_AR

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

Hi Adrien, after some discussion we found that change I've done in Mellanox PMD is not really necessary: size of array flow_types_mask[] is still 1 and the loop in patch for (i = 0; i < RTE_FLOW_MASK_ARRAY_SIZE; i++) info->flow_types_mask[i] = 0ULL; will work exactly in the same way a

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

On Tue, Jan 09, 2018 at 03:16:13PM +, Rybalchenko, Kirill wrote: > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Monday 4 December 2017 17:43 > > To: Rybalchenko, Kirill > > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > ; johnd...@cis

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

Hi, 09/01/2018 16:16, Rybalchenko, Kirill: > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > On Mon, Nov 27, 2017 at 12:29:47PM +, Kirill Rybalchenko wrote: > > > Increase the internal limit for flow types from 32 to 64 to support > > > future flow type extensions. > > > Change

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

> -Original Message- > From: Rybalchenko, Kirill > Sent: Monday, November 27, 2017 8:30 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; johnd...@cisco.com; neesc...@cisco.com; > adrien.mazarg...@6wind.com; nelio.laranje...@6wind.com; > ys...@mellanox.com; Lu, Wenzhuo ; Ananyev

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Monday 4 December 2017 17:43 > To: Rybalchenko, Kirill > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; johnd...@cisco.com; neesc...@cisco.com; > nelio.laranje...@6wind.com; ys...@mellanox.com; L

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

Hi maintainers What is your comments on this patch? As it affect Intel, ENIC and MLX NICs, I'd like to see the ACK from the maintainers. Then I can apply the patch. Hi Kirill I already saw a comments. Could you help to address it from 6wind. Regards, Helin > -Original Message- > From:

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

Hi Kirill, On Mon, Nov 27, 2017 at 12:29:47PM +, Kirill Rybalchenko wrote: > Increase the internal limit for flow types from 32 to 64 > to support future flow type extensions. > Change type of variables from uint32_t[] to uint64_t[]: > rte_eth_fdir_info.flow_types_mask > rte_eth_hash_globa