Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-20 Thread Thomas Monjalon
20/12/2018 11:53, Mattias Rönnblom: > On 2018-12-19 22:45, Thomas Monjalon wrote: > > 14/12/2018 21:28, Mattias Rönnblom: > >> On 2018-12-14 20:07, Jeff Shaw wrote: > > The code prior to this commit produced the following warning when > > compiled with "-Wvla -std=c90". > > > >

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-20 Thread Mattias Rönnblom
On 2018-12-19 22:45, Thomas Monjalon wrote: 14/12/2018 21:28, Mattias Rönnblom: On 2018-12-14 20:07, Jeff Shaw wrote: The code prior to this commit produced the following warning when compiled with "-Wvla -std=c90". warning: ISO C90 forbids variable length array ‘array’ [-Wvla] This comm

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-19 Thread Thomas Monjalon
14/12/2018 21:28, Mattias Rönnblom: > On 2018-12-14 20:07, Jeff Shaw wrote: > >>> The code prior to this commit produced the following warning when > >>> compiled with "-Wvla -std=c90". > >>> > >>> warning: ISO C90 forbids variable length array ‘array’ [-Wvla] > >>> > >>> This commit removes th

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Mattias Rönnblom
On 2018-12-14 20:07, Jeff Shaw wrote: The code prior to this commit produced the following warning when compiled with "-Wvla -std=c90". warning: ISO C90 forbids variable length array ‘array’ [-Wvla] This commit removes the variable length array from the PMD debug trace function by allocatin

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
On Fri, Dec 14, 2018 at 10:59:28AM -0800, Jeff Shaw wrote: > On Fri, Dec 14, 2018 at 10:36:03AM -0800, Stephen Hemminger wrote: > > On Fri, 14 Dec 2018 08:38:27 -0800 > > Jeff Shaw wrote: > > > > > Compilers that do not support the C11 standard, or do not implement > > > gcc extensions, may not s

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
On Fri, Dec 14, 2018 at 07:36:38PM +0100, Mattias Rönnblom wrote: > On 2018-12-14 17:38, Jeff Shaw wrote: > > Compilers that do not support the C11 standard, or do not implement > > gcc extensions, may not support variable length arrays. > > > > VLAs are a C99 thing. You're right, my mistake. >

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
On Fri, Dec 14, 2018 at 10:36:03AM -0800, Stephen Hemminger wrote: > On Fri, 14 Dec 2018 08:38:27 -0800 > Jeff Shaw wrote: > > > Compilers that do not support the C11 standard, or do not implement > > gcc extensions, may not support variable length arrays. > > > > The code prior to this commit p

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Mattias Rönnblom
On 2018-12-14 17:38, Jeff Shaw wrote: Compilers that do not support the C11 standard, or do not implement gcc extensions, may not support variable length arrays. VLAs are a C99 thing. The code prior to this commit produced the following warning when compiled with "-Wvla -std=c90". warnin

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Stephen Hemminger
On Fri, 14 Dec 2018 08:38:27 -0800 Jeff Shaw wrote: > Compilers that do not support the C11 standard, or do not implement > gcc extensions, may not support variable length arrays. > > The code prior to this commit produced the following warning when > compiled with "-Wvla -std=c90". > > warni