Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-10-26 Thread Thomas Monjalon
04/09/2017 15:02, Bruce Richardson: > Couple of other comments on this code area that should be taken into > account: > 1. the indentation of the asm code looks wrong, and should probably be >fixed to make it more readable. > 2. the comment on the "D" register is wrong as it refers to ebx > 3.

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-09-04 Thread Bruce Richardson
+Correct email for Thomas. On Mon, Sep 04, 2017 at 02:02:05PM +0100, Bruce Richardson wrote: > On Fri, Feb 10, 2017 at 11:53:06AM +0100, Thomas Monjalon wrote: > > 2017-02-10 10:39, Hunt, David: > > > > > > On 9/2/2017 4:53 PM, Thomas Monjalon wrote: > > > > 2016-11-06 22:09, Thomas Monjalon: > >

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-09-04 Thread Bruce Richardson
On Fri, Feb 10, 2017 at 11:53:06AM +0100, Thomas Monjalon wrote: > 2017-02-10 10:39, Hunt, David: > > > > On 9/2/2017 4:53 PM, Thomas Monjalon wrote: > > > 2016-11-06 22:09, Thomas Monjalon: > > >> 2016-09-29 18:34, Thomas Monjalon: > > >>> 2016-09-30 02:54, Nikhil Rao: > > The original code

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-03-09 Thread Thomas Monjalon
2017-02-10 08:46, Stephen Hemminger: > On Fri, 10 Feb 2017 11:53:06 +0100 > Thomas Monjalon wrote: > > > 2017-02-10 10:39, Hunt, David: > > > > > > On 9/2/2017 4:53 PM, Thomas Monjalon wrote: > > > > 2016-11-06 22:09, Thomas Monjalon: > > > >> 2016-09-29 18:34, Thomas Monjalon: > > > >>> 2

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-10 Thread Stephen Hemminger
On Fri, 10 Feb 2017 11:53:06 +0100 Thomas Monjalon wrote: > 2017-02-10 10:39, Hunt, David: > > > > On 9/2/2017 4:53 PM, Thomas Monjalon wrote: > > > 2016-11-06 22:09, Thomas Monjalon: > > >> 2016-09-29 18:34, Thomas Monjalon: > > >>> 2016-09-30 02:54, Nikhil Rao: > > The original co

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-10 Thread Hunt, David
On 10/2/2017 10:53 AM, Thomas Monjalon wrote: 2017-02-10 10:39, Hunt, David: On 9/2/2017 4:53 PM, Thomas Monjalon wrote: 2016-11-06 22:09, Thomas Monjalon: 2016-09-29 18:34, Thomas Monjalon: 2016-09-30 02:54, Nikhil Rao: The original code used movl instead of xchgl, this caused rte_atomic6

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-10 Thread Thomas Monjalon
2017-02-10 10:39, Hunt, David: > > On 9/2/2017 4:53 PM, Thomas Monjalon wrote: > > 2016-11-06 22:09, Thomas Monjalon: > >> 2016-09-29 18:34, Thomas Monjalon: > >>> 2016-09-30 02:54, Nikhil Rao: > The original code used movl instead of xchgl, this caused > rte_atomic64_cmpset to use ebx a

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-10 Thread Hunt, David
On 9/2/2017 4:53 PM, Thomas Monjalon wrote: 2016-11-06 22:09, Thomas Monjalon: 2016-09-29 18:34, Thomas Monjalon: 2016-09-30 02:54, Nikhil Rao: The original code used movl instead of xchgl, this caused rte_atomic64_cmpset to use ebx as the lower dword of the source to cmpxchg8b instead of the

Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2017-02-09 Thread Thomas Monjalon
2016-11-06 22:09, Thomas Monjalon: > 2016-09-29 18:34, Thomas Monjalon: > > 2016-09-30 02:54, Nikhil Rao: > > > The original code used movl instead of xchgl, this caused > > > rte_atomic64_cmpset to use ebx as the lower dword of the source > > > to cmpxchg8b instead of the lower dword of function a