Re: [dpdk-dev] [PATCH] eal/ppc: fix redefine bool type

2020-04-30 Thread Ori Kam
> -Original Message- > From: David Marchand > Sent: Thursday, April 30, 2020 12:04 PM > To: Ori Kam > Cc: Thomas Monjalon ; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko ; David Christensen > ; dev ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH] e

Re: [dpdk-dev] [PATCH] eal/ppc: fix redefine bool type

2020-04-30 Thread David Marchand
On Thu, Apr 30, 2020 at 10:53 AM Ori Kam wrote: > > > diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h > > b/lib/librte_eal/ppc/include/rte_memcpy.h > > > index 25311ba..d234e21 100644 > > > --- a/lib/librte_eal/ppc/include/rte_memcpy.h > > > +++ b/lib/librte_eal/ppc/include/rte_memcpy.h > > >

Re: [dpdk-dev] [PATCH] eal/ppc: fix redefine bool type

2020-04-30 Thread Ori Kam
Hi David, I will add your code. Thanks, Ori > -Original Message- > From: David Christensen > Sent: Tuesday, April 28, 2020 9:20 PM > To: Ori Kam ; Thomas Monjalon > ; Matan Azrad ; Shahaf > Shuler ; Slava Ovsiienko > > Cc: dev@dpdk.org; ferruh.yi...@intel.com > Subject: Re: [PATCH] ea

Re: [dpdk-dev] [PATCH] eal/ppc: fix redefine bool type

2020-04-30 Thread Ori Kam
Hi David, > -Original Message- > From: David Marchand > Sent: Wednesday, April 29, 2020 11:17 AM > To: Ori Kam > Cc: Thomas Monjalon ; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko ; David Christensen > ; dev ; Yigit, Ferruh > > Subject: Re: [

Re: [dpdk-dev] [PATCH] eal/ppc: fix redefine bool type

2020-04-29 Thread David Marchand
On Tue, Apr 28, 2020 at 9:59 AM Ori Kam wrote: > > The AltiVec header file breaks boolean type. [1] [2] > > Currently the workaround was located only in mlx5 device. > Adding the trace module caused this issue to appear again, due to > order of includes, it keeps overriding the local fix. > > This

Re: [dpdk-dev] [PATCH] eal/ppc: fix redefine bool type

2020-04-28 Thread David Christensen
Fixes: 725f5dd0bfb5 ("net/mlx5: fix build on PPC64") Signed-off-by: Ori Kam --- There are a couple of other uses that should be covered in the patch: diff --git a/drivers/net/i40e/i40e_rxtx_vec_altivec.c b/drivers/net/i40e/i40e_rxtx_vec_altivec.c index 5fa92bf92..72bd410fc 100644 --- a/driv