Re: [dpdk-dev] [PATCH] devtools: return error on failure

2020-07-30 Thread Thomas Monjalon
25/06/2019 19:01, Ferruh Yigit: > Currently script is always returning success, returning failure on error > helps on using script on automation tools. > > Signed-off-by: Ferruh Yigit > --- > devtools/check-git-log.sh | 56 ++- > 1 file changed, 43 insertions(

Re: [dpdk-dev] [PATCH] devtools: return error on failure

2019-06-28 Thread Bruce Richardson
On Fri, Jun 28, 2019 at 09:27:47AM -0700, Stephen Hemminger wrote: > On Tue, 25 Jun 2019 18:01:06 +0100 > Ferruh Yigit wrote: > > > Currently script is always returning success, returning failure on error > > helps on using script on automation tools. > > > > Signed-off-by: Ferruh Yigit > > Lo

Re: [dpdk-dev] [PATCH] devtools: return error on failure

2019-06-28 Thread Stephen Hemminger
On Tue, 25 Jun 2019 18:01:06 +0100 Ferruh Yigit wrote: > Currently script is always returning success, returning failure on error > helps on using script on automation tools. > > Signed-off-by: Ferruh Yigit Looks good, but maybe this script is getting complex enough that it should be python?