Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-26 Thread Trahe, Fiona
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, March 24, 2018 1:02 AM > To: Trahe, Fiona > Cc: dev@dpdk.org; ahmed.mans...@nxp.com; shally.ve...@cavium.com; De Lara > Guarch, Pablo > ; fiona.tr...@gmail.com > Subjec

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-23 Thread Thomas Monjalon
23/03/2018 19:08, Trahe, Fiona: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 02/02/2018 19:25, Fiona Trahe: > > > lib/librte_compressdev/rte_comp.h | 503 > > > > Why rte_comp.h instead of the more consistent rte_compress.h? > [Fiona] I did originally...

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-23 Thread Trahe, Fiona
> Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API > > 02/02/2018 19:25, Fiona Trahe: > > config/common_base | 6 + > > doc/api/doxy-api-index.md | 1 + > > doc/api/doxy-api.conf

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-15 Thread Trahe, Fiona
Sunila > ; Challa, Mahipal ; Jain, > Deepak K > ; Hemant Agrawal ; Roy Pledge > ; Youri Querry ; Daly, Lee > ; > Jozwiak, TomaszX ; Alok Makhariya > ; Shreyansh > Jain > Subject: RE: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative > > @Trahe, Fiona&

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-14 Thread Verma, Shally
Sunila >; Challa, Mahipal >; Jain, Deepak K ; Hemant >Agrawal ; Roy >Pledge ; Youri Querry ; Daly, Lee >; Jozwiak, TomaszX >; Alok Makhariya ; >Shreyansh Jain >Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative > >Hi All, > >Sticking w

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-14 Thread Ahmed Mansour
>> ; Sahu, Sunila >> ; Challa, Mahipal ; Jain, >> Deepak K >> ; Hemant Agrawal ; Roy >> Pledge >> ; Youri Querry ; Daly, Lee >> ; >> Jozwiak, TomaszX >> Subject: RE: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative >&g

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-14 Thread Trahe, Fiona
hmed Mansour > >; > dev@dpdk.org > >Cc: De Lara Guarch, Pablo ; Athreya, > >Narayana Prasad > ; > >Gupta, Ashish ; Sahu, Sunila > >; Challa, Mahipal > >; Jain, Deepak K ; > >Hemant Agrawal > ; Roy > >Pledge ; Youri Querry ; Daly, Lee > ;

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-14 Thread Verma, Shally
>; Jain, Deepak K ; Hemant >Agrawal ; Roy >Pledge ; Youri Querry ; Daly, Lee >; Jozwiak, TomaszX >; Trahe, Fiona >Subject: RE: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative > >Hi Shally, > >> -Original Message- >> From: Verma, Shally

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-13 Thread Trahe, Fiona
gt; Sahu, Sunila > ; Challa, Mahipal ; Jain, > Deepak K > ; Hemant Agrawal ; Roy Pledge > ; Youri Querry ; > fiona.tr...@gmail.com; Daly, Lee > ; Jozwiak, TomaszX > Subject: RE: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative > > HI Fiona > > So I

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-13 Thread Ananyev, Konstantin
Hi Fiona, > Hi Shally, Ahmed, and anyone else interested in compressdev, > > I mentioned last week that we've been exploring using something other than > mbufs to pass src/dst buffers to compressdev PMDs. > > Reasons: > - mbuf data is limited to 64k-1 in each segment of a chained mbuf. Data fo

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-13 Thread Verma, Shally
erry ; >fiona.tr...@gmail.com; Daly, Lee ; >Jozwiak, TomaszX >Subject: RE: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative > >Hi Shally, Ahmed, and anyone else interested in compressdev, > >I mentioned last week that we've been exploring using something other t

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-12 Thread Trahe, Fiona
Hi Shally, Ahmed, and anyone else interested in compressdev, I mentioned last week that we've been exploring using something other than mbufs to pass src/dst buffers to compressdev PMDs. Reasons: - mbuf data is limited to 64k-1 in each segment of a chained mbuf. Data for compression can be

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-06 Thread Ahmed Mansour
gt; Narayana Prasad ; >> Gupta, Ashish ; Sahu, Sunila >> ; Challa, Mahipal >> ; Jain, Deepak K ; >> Hemant Agrawal ; Roy >> Pledge ; Youri Querry >> Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API >> >> On 3/2/2018 4:53 AM, Trahe,

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-05 Thread Verma, Shally
>; Jain, Deepak K ; Hemant >Agrawal ; Roy >Pledge ; Youri Querry >Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API > >On 3/2/2018 4:53 AM, Trahe, Fiona wrote: >> >>> On 3/1/2018 9:41 AM, Trahe, Fiona wrote: >>>> Hi Shally >>>> &g

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-02 Thread Ahmed Mansour
re. > > > Regards, > Fiona > >> -Original Message- >> From: Verma, Shally [mailto:shally.ve...@cavium.com] >> Sent: Tuesday, February 27, 2018 5:54 AM >> To: Ahmed Mansour ; Trahe, Fiona >> ; >> dev@dpdk.org >> Cc: De Lara Guarch, Pablo

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-02 Thread Ahmed Mansour
On 3/2/2018 4:53 AM, Trahe, Fiona wrote: > >> On 3/1/2018 9:41 AM, Trahe, Fiona wrote: >>> Hi Shally >>> >>> //snip// [Shally] This looks better to me. So it mean app would always call xform_init() for stateless and attach >> an updated priv_xform to ops (depending upon if there's s

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-02 Thread Trahe, Fiona
> ; Challa, Mahipal ; Jain, > Deepak K > ; Hemant Agrawal ; Roy Pledge > ; Youri Querry > Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API > > On 3/1/2018 9:41 AM, Trahe, Fiona wrote: > > Hi Shally > > > > //snip// > >> [Shally] This

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-01 Thread Ahmed Mansour
On 3/1/2018 9:41 AM, Trahe, Fiona wrote: > Hi Shally > > //snip// >> [Shally] This looks better to me. So it mean app would always call >> xform_init() for stateless and attach an >> updated priv_xform to ops (depending upon if there's shareable or not). So >> it does not need to have >> NULL poi

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-01 Thread Trahe, Fiona
Hi Shally //snip// > [Shally] This looks better to me. So it mean app would always call > xform_init() for stateless and attach an > updated priv_xform to ops (depending upon if there's shareable or not). So it > does not need to have > NULL pointer on priv_xform. right? > [Fiona] yes. The PMD

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-28 Thread Verma, Shally
, Mahipal >; Jain, Deepak K ; Hemant >Agrawal ; Roy >Pledge ; Youri Querry ; Trahe, >Fiona >Subject: RE: [dpdk-dev] [PATCH] compressdev: implement API > >Hi Ahmed, Shally, > >So just to capture what we concluded in the call today: > > - There's no requirem

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-28 Thread Trahe, Fiona
d Mansour ; Trahe, Fiona > ; > dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Athreya, Narayana > Prasad > ; Gupta, Ashish ; > Sahu, Sunila > ; Challa, Mahipal ; Jain, > Deepak K > ; Hemant Agrawal ; Roy Pledge > ; Youri Querry > Subject: RE: [dpdk-dev] [PATCH] co

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-26 Thread Verma, Shally
>; Jain, Deepak K ; Hemant >Agrawal ; Roy >Pledge ; Youri Querry >Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API > >> Hi Fiona, Ahmed >>> Hi Fiona, >>> >>> Thanks for starting this discussion. In the current API the user must >>>

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-26 Thread Verma, Shally
>; Jain, Deepak K ; Hemant >Agrawal ; Roy >Pledge ; Youri Querry >Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API > >>> Hi Fiona, >>> >>> Thanks for starting this discussion. In the current API the user must >>> make 12 API calls just

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-26 Thread Ahmed Mansour
> Hi Fiona, Ahmed >> Hi Fiona, >> >> Thanks for starting this discussion. In the current API the user must >> make 12 API calls just to get information to compress. Maybe there is a >> way to simplify. At least for some use cases (stateless). I think a call >> sometime next week would be good to he

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-26 Thread Ahmed Mansour
>> Hi Fiona, >> >> Thanks for starting this discussion. In the current API the user must >> make 12 API calls just to get information to compress. Maybe there is a >> way to simplify. At least for some use cases (stateless). I think a call >> sometime next week would be good to help clarify coalesc

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-26 Thread Verma, Shally
t;; Challa, Mahipal >; Jain, Deepak K ; Hemant >Agrawal ; Roy >Pledge ; Youri Querry >Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API > >Hi Fiona, > >Thanks for starting this discussion. In the current API the user must >make 12 API calls just to get information to

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-26 Thread Trahe, Fiona
gt; Sahu, Sunila > ; Challa, Mahipal ; Jain, > Deepak K > ; Hemant Agrawal ; Roy Pledge > ; Youri Querry > Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API > > Hi Fiona, > > Thanks for starting this discussion. In the current API the user must > make 12 API ca

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-23 Thread Ahmed Mansour
Hi Fiona, Thanks for starting this discussion. In the current API the user must make 12 API calls just to get information to compress. Maybe there is a way to simplify. At least for some use cases (stateless). I think a call sometime next week would be good to help clarify coalesce some of the com

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-21 Thread Trahe, Fiona
We've been struggling with the idea of session in compressdev. Is it really a session? - It's not in the same sense as cryptodev where it's used to hold a key, and maps to a Security Association. - It's a set of immutable data that is needed with the op and stream to perform the operation. -

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-04 Thread Thomas Monjalon
02/02/2018 19:25, Fiona Trahe: > config/common_base | 6 + > doc/api/doxy-api-index.md | 1 + > doc/api/doxy-api.conf | 1 + > lib/Makefile | 3 + > lib/librte_compre

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-04 Thread Thomas Monjalon
02/02/2018 19:25, Fiona Trahe: > - Used dynamic logging [...] > --- a/lib/librte_eal/common/include/rte_log.h > +++ b/lib/librte_eal/common/include/rte_log.h > @@ -60,6 +60,7 @@ extern struct rte_logs rte_logs; > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > #define RTE_LOGTYPE_E