Re: [dpdk-dev] [PATCH] checkpatches.sh: Add checks for ABI symbol addition

2018-01-15 Thread Neil Horman
On Mon, Jan 15, 2018 at 10:52:25PM +0100, Thomas Monjalon wrote: > 15/01/2018 20:05, Neil Horman: > > Recently, some additional patches were added to allow for programmatic > > marking of C symbols as experimental. The addition of these markers is > > dependent on the manual addition of exported s

Re: [dpdk-dev] [PATCH] checkpatches.sh: Add checks for ABI symbol addition

2018-01-15 Thread Neil Horman
On Mon, Jan 15, 2018 at 02:20:38PM -0800, Stephen Hemminger wrote: > On Mon, 15 Jan 2018 14:05:45 -0500 > Neil Horman wrote: > > > > > +build_map_changes() > > +{ > > + local fname=$1 > > + local mapdb=$2 > > + > > + cat $fname | filterdiff -i *.map | awk ' > > You don't need cat, use sh

Re: [dpdk-dev] [PATCH] checkpatches.sh: Add checks for ABI symbol addition

2018-01-15 Thread Stephen Hemminger
On Mon, 15 Jan 2018 14:05:45 -0500 Neil Horman wrote: > > +build_map_changes() > +{ > + local fname=$1 > + local mapdb=$2 > + > + cat $fname | filterdiff -i *.map | awk ' You don't need cat, use shell redirection same for later while loop. > + BEGIN {map="";sym="";ar="

Re: [dpdk-dev] [PATCH] checkpatches.sh: Add checks for ABI symbol addition

2018-01-15 Thread Thomas Monjalon
15/01/2018 20:05, Neil Horman: > Recently, some additional patches were added to allow for programmatic > marking of C symbols as experimental. The addition of these markers is > dependent on the manual addition of exported symbols to the EXPERIMENTAL > section of the corresponding libraries versi