Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-09-23 Thread David Marchand
On Fri, Jul 10, 2020 at 12:08 PM Thomas Monjalon wrote: > > It took me some time to understand this code... > > Anyway, we have a regression in the librte_pci. > > This is where the fix should be. > > Yes, I am going to send a fix. > > > We can cleanup this code later. > > Yes please, this functio

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-10 Thread Zhang, AlvinX
> -Original Message- > From: David Marchand > Sent: Friday, July 10, 2020 5:54 PM > To: Zhang, AlvinX > Cc: dev ; Xing, Beilei ; Guo, Jia > > Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource > > On Wed, Jul 8, 2020 at 11:26 AM wrote

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-10 Thread Thomas Monjalon
10/07/2020 12:07, Thomas Monjalon: > 10/07/2020 11:54, David Marchand: > > On Wed, Jul 8, 2020 at 11:26 AM wrote: > > > From: Alvin Zhang > > > > > > When mapping a PCI BAR containing an MSI-X table, some devices do not > > > need to actually map this BAR or only need to map part of them, which >

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-10 Thread Thomas Monjalon
10/07/2020 11:54, David Marchand: > On Wed, Jul 8, 2020 at 11:26 AM wrote: > > From: Alvin Zhang > > > > When mapping a PCI BAR containing an MSI-X table, some devices do not > > need to actually map this BAR or only need to map part of them, which > > may cause the mapping to fail. Now some chec

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-10 Thread David Marchand
On Wed, Jul 8, 2020 at 11:26 AM wrote: > > From: Alvin Zhang > > When mapping a PCI BAR containing an MSI-X table, some devices do not > need to actually map this BAR or only need to map part of them, which > may cause the mapping to fail. Now some checks are added and a non-NULL > initial value

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-08 Thread Xia, Chenbo
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, July 9, 2020 1:14 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: David Marchand ; Tal Shnaiderman > ; Burakov, Anatoly ; > tho...@monjalon.net > Subject: RE: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-08 Thread Zhang, AlvinX
> Subject: RE: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource > > Hi Alvin, > > CC the maintainers. Comments below. > > > -Original Message- > > From: dev On Behalf Of alvinx.zh...@intel.com > > Sent: Wednesday, July 8, 2020 5:25 PM > > To: de

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-08 Thread Xiao, QimaiX
Tested-by: Xiao Qimai Regards, Xiao Qimai > -Original Message- > From: dev On Behalf Of alvinx.zh...@intel.com > Sent: Wednesday, July 8, 2020 5:25 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia > Subject: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource > > From: Alvin Zhang >

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-08 Thread Xia, Chenbo
Hi Alvin, CC the maintainers. Comments below. > -Original Message- > From: dev On Behalf Of alvinx.zh...@intel.com > Sent: Wednesday, July 8, 2020 5:25 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia > Subject: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource > > From: Alvin Zhang

Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource

2020-07-08 Thread David Marchand
On Wed, Jul 8, 2020 at 11:26 AM wrote: > > From: Alvin Zhang > > When mapping a PCI BAR containing an MSI-X table, some devices do not > need to actually map this BAR or only need to map part of them, which > may cause the mapping to fail. Now some checks are added and a non-NULL > initial value