Re: [dpdk-dev] [PATCH] app/testpmd: always build VF and MACsec functions

2017-06-20 Thread Thomas Monjalon
> > These functions are supported only on ixgbe. > > However, they should appear in the help and returns an error > > if the function is not supported or not enabled. > > > > Signed-off-by: Thomas Monjalon > Acked-by: Jingjing Wu Applied

Re: [dpdk-dev] [PATCH] app/testpmd: always build VF and MACsec functions

2017-06-20 Thread Thomas Monjalon
20/06/2017 08:53, Tiwei Bie: > On Thu, Jun 15, 2017 at 01:02:21PM +0200, Thomas Monjalon wrote: > > These functions are supported only on ixgbe. > [...] > > @@ -3013,15 +3013,21 @@ set_vf_traffic(portid_t port_id, uint8_t is_rx, > > uint16_t vf, uint8_t on) > > > > if (diag == 0) > >

Re: [dpdk-dev] [PATCH] app/testpmd: always build VF and MACsec functions

2017-06-19 Thread Tiwei Bie
On Thu, Jun 15, 2017 at 01:02:21PM +0200, Thomas Monjalon wrote: > These functions are supported only on ixgbe. [...] > @@ -3013,15 +3013,21 @@ set_vf_traffic(portid_t port_id, uint8_t is_rx, > uint16_t vf, uint8_t on) > > if (diag == 0) > return; > - if(is_rx) > + if

Re: [dpdk-dev] [PATCH] app/testpmd: always build VF and MACsec functions

2017-06-19 Thread Wu, Jingjing
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, June 15, 2017 7:02 PM > To: Wu, Jingjing > Cc: Lu, Wenzhuo ; dev@dpdk.org > Subject: [PATCH] app/testpmd: always build VF and MACsec functions > > These functions are supported only on ixgbe. > H