Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Konstantin Ananyev
06/05/2022 17:39, Bruce Richardson пишет: On Fri, May 06, 2022 at 09:33:41AM -0700, Stephen Hemminger wrote: On Fri, 6 May 2022 16:28:41 +0100 Bruce Richardson wrote: On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: On Thu, May 05, 2022 at 10:59:32PM +, Honnappa N

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Bruce Richardson
On Fri, May 06, 2022 at 09:33:41AM -0700, Stephen Hemminger wrote: > On Fri, 6 May 2022 16:28:41 +0100 > Bruce Richardson wrote: > > > On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wro

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Bruce Richardson
On Fri, May 06, 2022 at 08:41:12AM -0700, Stephen Hemminger wrote: > On Fri, 6 May 2022 00:24:34 -0700 > Tyler Retzlaff wrote: > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > > Thanks Stephen. Do you see any performance difference with this change? > > > > as a

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Stephen Hemminger
On Fri, 6 May 2022 16:28:41 +0100 Bruce Richardson wrote: > On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: > > > > > > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > > > Thanks Stephen. Do you see any performance difference with this cha

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Stephen Hemminger
On Fri, 6 May 2022 00:24:34 -0700 Tyler Retzlaff wrote: > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > Thanks Stephen. Do you see any performance difference with this change? > > as a matter of due diligence i think a comparison should be made just > to be confiden

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Bruce Richardson
On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: > > > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > > Thanks Stephen. Do you see any performance difference with this change? > > > > as a matter of due diligence i think a comparison should be

RE: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Honnappa Nagarahalli
> > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > Thanks Stephen. Do you see any performance difference with this change? > > as a matter of due diligence i think a comparison should be made just to be > confident nothing is regressing. > > i support this change in p

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Tyler Retzlaff
On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > Thanks Stephen. Do you see any performance difference with this change? as a matter of due diligence i think a comparison should be made just to be confident nothing is regressing. i support this change in principal since it

RE: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Honnappa Nagarahalli
> > > Thanks Stephen. Do you see any performance difference with this change? > > > > > -Original Message- > > > From: Stephen Hemminger > > > Sent: Thursday, May 5, 2022 5:46 PM > > > To: dev@dpdk.org > > > Cc: Stephen Hemminger > > > Subject: [RFC] rte_ring: don't use always inline >

Re: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Stephen Hemminger
On Thu, 5 May 2022 16:10:27 -0700 Stephen Hemminger wrote: > On Thu, 5 May 2022 22:59:32 + > Honnappa Nagarahalli wrote: > > > Thanks Stephen. Do you see any performance difference with this change? > > > > > -Original Message- > > > From: Stephen Hemminger > > > Sent: Thursday,

Re: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Stephen Hemminger
On Thu, 5 May 2022 22:59:32 + Honnappa Nagarahalli wrote: > Thanks Stephen. Do you see any performance difference with this change? > > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, May 5, 2022 5:46 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subjec

RE: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Honnappa Nagarahalli
Thanks Stephen. Do you see any performance difference with this change? > -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 5, 2022 5:46 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [RFC] rte_ring: don't use always inline > > Forcing compiler to inline with