Re: [PATCH v8 1/5] eal: add lcore info in telemetry

2023-02-06 Thread fengchengwen
On 2023/2/6 19:46, Robin Jarry wrote: > fengchengwen, Feb 06, 2023 at 12:22: >> Just invoke callback on one specific lcore. >> >> In this patch, the lcore_telemetry_info_cb() only valid on specific lcore, >> but it was implements by rte_lcore_iterate which will iterate all lcores. > > Ok I see. I

Re: [PATCH v8 1/5] eal: add lcore info in telemetry

2023-02-06 Thread Robin Jarry
fengchengwen, Feb 06, 2023 at 12:22: Just invoke callback on one specific lcore. In this patch, the lcore_telemetry_info_cb() only valid on specific lcore, but it was implements by rte_lcore_iterate which will iterate all lcores. Ok I see. I don't think this would be worth the effort. There

Re: [PATCH v8 1/5] eal: add lcore info in telemetry

2023-02-06 Thread fengchengwen
On 2023/2/6 16:22, Robin Jarry wrote: > fengchengwen, Feb 06, 2023 at 04:50: >> > +    return rte_lcore_iterate(lcore_telemetry_info_cb, &info); >> >> lcore_iterate will iterate and find the lcore. >> >> How about add one new API e.g. rte_lcore_cb(xxx) ? > > Hi fengchengwen, > > what would that n

Re: [PATCH v8 1/5] eal: add lcore info in telemetry

2023-02-06 Thread Robin Jarry
fengchengwen, Feb 06, 2023 at 04:50: > + return rte_lcore_iterate(lcore_telemetry_info_cb, &info); lcore_iterate will iterate and find the lcore. How about add one new API e.g. rte_lcore_cb(xxx) ? Hi fengchengwen, what would that new API do?

Re: [PATCH v8 1/5] eal: add lcore info in telemetry

2023-02-05 Thread fengchengwen
Hi Robin, On 2023/2/2 21:43, Robin Jarry wrote: > Report the same information than rte_lcore_dump() in the telemetry > API into /eal/lcore/list and /eal/lcore/info,ID. > > Example: > > --> /eal/lcore/info,3 > { > "/eal/lcore/info": { > "lcore_id": 3, > "socket": 0, > "r