Re: [PATCH v6] hash: add XOR32 hash function

On 2023-06-16 19:15, Bili Dong wrote: Thanks Vladimir for your suggestion! Indeed your version looks cleaner. I will make the changes (including the new test case you mentioned) and prepare a new version this weekend. Regards, Bili On Thu, Jun 15, 2023 at 10:15 AM Vladimir Medvedkin mailto:

Re: [PATCH v6] hash: add XOR32 hash function

Thanks Vladimir for your suggestion! Indeed your version looks cleaner. I will make the changes (including the new test case you mentioned) and prepare a new version this weekend. Regards, Bili On Thu, Jun 15, 2023 at 10:15 AM Vladimir Medvedkin wrote: > Hi Bili, > > The rte_hash_xor32() imple

Re: [PATCH v6] hash: add XOR32 hash function

Hi Bili, The rte_hash_xor32() implementation looks a bit messy with respect to byte ordering, i.e. in case when data_len >= 8 init_val is byte swapped, but in other cases the data is byte swapped. Maybe it could be implemented like: static inline uint32_t rte_hash_xor32(const void *data, uint32_t

Re: [PATCH v6] hash: add XOR32 hash function

Any review please? This patch is dying... 21/02/2023 20:37, Bili Dong: > An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its > use case in P4. We implement it in this patch so it could be easily > registered in the pipeline later. > > Signed-off-by: Bili Dong > --- > .mailmap

Re: [PATCH v6] hash: add XOR32 hash function

The reported performance issue is a mystery to me. Does anyone have an idea what's going on? Thanks, Bili On Tue, Feb 21, 2023 at 11:37 AM Bili Dong wrote: > An XOR32 hash is needed in the Software Switch (SWX) Pipeline for