Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-17 Thread Tyler Retzlaff
On Sat, Apr 15, 2023 at 03:52:27PM -0700, Stephen Hemminger wrote: > On Sun, 16 Apr 2023 00:41:54 +0200 > Morten Brørup wrote: > > > > > > > > /** > > > > > > > * Force a structure to be packed > > > > > > > */ > > > > > > > +#ifndef RTE_TOOLCHAIN_MSVC > > > > > > > #define __rte_packed __a

Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-15 Thread Stephen Hemminger
On Sun, 16 Apr 2023 00:41:54 +0200 Morten Brørup wrote: > > > > > > /** > > > > > > * Force a structure to be packed > > > > > > */ > > > > > > +#ifndef RTE_TOOLCHAIN_MSVC > > > > > > #define __rte_packed __attribute__((__packed__)) > > > > > > +#else > > > > > > +#define __rte_packed > > >

RE: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-15 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Saturday, 15 April 2023 22.52 > > On Sat, Apr 15, 2023 at 09:16:21AM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Friday, 14 April 2023 19.02 > > > > > > On Fri, Apr 14,

Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-15 Thread Tyler Retzlaff
On Sat, Apr 15, 2023 at 09:16:21AM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Friday, 14 April 2023 19.02 > > > > On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.c

RE: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-15 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Friday, 14 April 2023 19.02 > > On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Thursday, 13 April 2023 23.26 > > > > > > For now expand

Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-14 Thread Tyler Retzlaff
On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 13 April 2023 23.26 > > > > For now expand a lot of common rte macros empty. The catch here is we > > need to test that most of the macros do what they

Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-14 Thread Bruce Richardson
On Fri, Apr 14, 2023 at 02:39:03PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 14 April 2023 11.22 > > > > On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.c

RE: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-14 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 14 April 2023 11.22 > > On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Thursday, 13 April 2023 23.26 > > > > > > For now expand

Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-14 Thread Bruce Richardson
On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 13 April 2023 23.26 > > > > For now expand a lot of common rte macros empty. The catch here is we > > need to test that most of the macros do what they

RE: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-13 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 13 April 2023 23.26 > > For now expand a lot of common rte macros empty. The catch here is we > need to test that most of the macros do what they should but at the same > time they are blocking work needed to bootstrap