Re: [PATCH v5 1/7] eal/loongarch: support LoongArch architecture

2022-08-26 Thread zhoumin
Hi David, Thank you very much for your reminder. On Thu, Aug 25, 2022 at 22:04, David Marchand wrote: On Thu, Aug 25, 2022 at 3:56 PM David Marchand wrote: This is only a first pass. Additionnally, please run ./devtools/check-meson.py. I see tabulations where we expect spaces. OK, thanks.

Re: [PATCH v5 1/7] eal/loongarch: support LoongArch architecture

2022-08-26 Thread zhoumin
Hi David, I appreciate you giving me these helpful comments. On Thu, Aug 25, 2022 at 21:56, David Marchand wrote: This is only a first pass. On Wed, Aug 24, 2022 at 10:31 AM Min Zhou wrote: diff --git a/MAINTAINERS b/MAINTAINERS index 32ffdd1a61..f00b82b5ce 100644 --- a/MAINTAINERS +++ b/MAI

Re: [PATCH v5 1/7] eal/loongarch: support LoongArch architecture

2022-08-25 Thread David Marchand
On Thu, Aug 25, 2022 at 3:56 PM David Marchand wrote: > > This is only a first pass. Additionnally, please run ./devtools/check-meson.py. I see tabulations where we expect spaces. -- David Marchand

Re: [PATCH v5 1/7] eal/loongarch: support LoongArch architecture

2022-08-25 Thread David Marchand
This is only a first pass. On Wed, Aug 24, 2022 at 10:31 AM Min Zhou wrote: > diff --git a/MAINTAINERS b/MAINTAINERS > index 32ffdd1a61..f00b82b5ce 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -311,6 +311,12 @@ F: config/riscv/ > F: doc/guides/linux_gsg/cross_build_dpdk_for_riscv.rst > F