Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

2023-08-16 Thread Bruce Richardson
On Wed, Aug 16, 2023 at 04:57:07PM +0200, David Marchand wrote: > On Tue, Aug 15, 2023 at 5:24 PM Bruce Richardson > wrote: > > > > Rather than having the test suites listed out in the meson.build files > > and having to have them enabled/disabled selectively based on what libs > > are being built

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

2023-08-16 Thread David Marchand
On Tue, Aug 15, 2023 at 5:24 PM Bruce Richardson wrote: > > Rather than having the test suites listed out in the meson.build files > and having to have them enabled/disabled selectively based on what libs > are being built, pull the tests to run from the source files which were > added to the buil

RE: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

2023-08-16 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Wednesday, 16 August 2023 15.17 > > Hi, > > On Wed, Aug 16, 2023 at 01:33:46PM +0100, Bruce Richardson wrote: > > On Wed, Aug 16, 2023 at 01:40:41PM +0200, David Marchand wrote: > > > On Wed, Aug 16, 2023 at 1:15 PM David Marchand > > >

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

2023-08-16 Thread Bruce Richardson
On Wed, Aug 16, 2023 at 03:35:47PM +0200, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Wednesday, 16 August 2023 15.17 > > > > Hi, > > > > On Wed, Aug 16, 2023 at 01:33:46PM +0100, Bruce Richardson wrote: > > > On Wed, Aug 16, 2023 at 01:40:41PM +0200, Dav

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

2023-08-16 Thread Olivier Matz
Hi, On Wed, Aug 16, 2023 at 01:33:46PM +0100, Bruce Richardson wrote: > On Wed, Aug 16, 2023 at 01:40:41PM +0200, David Marchand wrote: > > On Wed, Aug 16, 2023 at 1:15 PM David Marchand > > wrote: > > > > > > On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson > > > wrote: > > > > These lines here

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

2023-08-16 Thread Bruce Richardson
On Wed, Aug 16, 2023 at 01:40:41PM +0200, David Marchand wrote: > On Wed, Aug 16, 2023 at 1:15 PM David Marchand > wrote: > > > > On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson > > wrote: > > > These lines here seem to be exposing a bug in the mempool unit tests for > > > shared builds, which i

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

2023-08-16 Thread David Marchand
On Wed, Aug 16, 2023 at 1:15 PM David Marchand wrote: > > On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson > wrote: > > These lines here seem to be exposing a bug in the mempool unit tests for > > shared builds, which is why we have a CI failure. > > > > The mempool unit tests use the mempool "cr

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

2023-08-16 Thread David Marchand
On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson wrote: > These lines here seem to be exposing a bug in the mempool unit tests for > shared builds, which is why we have a CI failure. > > The mempool unit tests use the mempool "create_empty" API, and then call > the populate APIs to finish setting

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

2023-08-16 Thread Bruce Richardson
On Tue, Aug 15, 2023 at 04:10:49PM +0100, Bruce Richardson wrote: > Rather than having the test suites listed out in the meson.build files > and having to have them enabled/disabled selectively based on what libs > are being built, pull the tests to run from the source files which were > added to t