RE: [EXT] Re: [PATCH v3 2/5] mbuf: add second dynamic field member for VA only build

2022-09-28 Thread Shijith Thotton
>> > > mbuf physical address field is not used in builds which only uses VA. It >> > > is used to expand the dynamic field area. >> > > >> > > Signed-off-by: Shijith Thotton >> > >> > We cannot condition the use of the dynamic field. >> > I think it is enough justification to reject this patch.

Re: [PATCH v3 2/5] mbuf: add second dynamic field member for VA only build

2022-09-28 Thread Stephen Hemminger
On Wed, 28 Sep 2022 14:52:47 +0200 Olivier Matz wrote: > On Wed, Sep 28, 2022 at 09:24:51AM +0200, Thomas Monjalon wrote: > > 21/09/2022 15:56, Shijith Thotton: > > > mbuf physical address field is not used in builds which only uses VA. It > > > is used to expand the dynamic field area. > > >

Re: [PATCH v3 2/5] mbuf: add second dynamic field member for VA only build

2022-09-28 Thread Thomas Monjalon
28/09/2022 14:52, Olivier Matz: > On Wed, Sep 28, 2022 at 09:24:51AM +0200, Thomas Monjalon wrote: > > 21/09/2022 15:56, Shijith Thotton: > > > mbuf physical address field is not used in builds which only uses VA. It > > > is used to expand the dynamic field area. > > > > > > Signed-off-by: Shijit

Re: [PATCH v3 2/5] mbuf: add second dynamic field member for VA only build

2022-09-28 Thread Olivier Matz
On Wed, Sep 28, 2022 at 09:24:51AM +0200, Thomas Monjalon wrote: > 21/09/2022 15:56, Shijith Thotton: > > mbuf physical address field is not used in builds which only uses VA. It > > is used to expand the dynamic field area. > > > > Signed-off-by: Shijith Thotton > > We cannot condition the use

Re: [PATCH v3 2/5] mbuf: add second dynamic field member for VA only build

2022-09-28 Thread Olivier Matz
Hi, On Wed, Sep 21, 2022 at 07:26:18PM +0530, Shijith Thotton wrote: > mbuf physical address field is not used in builds which only uses VA. It > is used to expand the dynamic field area. > > Signed-off-by: Shijith Thotton > --- > lib/mbuf/rte_mbuf_core.h | 26 +- > lib/

Re: [PATCH v3 2/5] mbuf: add second dynamic field member for VA only build

2022-09-28 Thread Thomas Monjalon
21/09/2022 15:56, Shijith Thotton: > mbuf physical address field is not used in builds which only uses VA. It > is used to expand the dynamic field area. > > Signed-off-by: Shijith Thotton We cannot condition the use of the dynamic field. I think it is enough justification to reject this patch.