Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation

2022-09-14 Thread Maxime Coquelin
On 9/14/22 11:45, Thomas Monjalon wrote: 14/09/2022 11:34, Maxime Coquelin: On 9/14/22 11:15, Thomas Monjalon wrote: 14/09/2022 09:14, Maxime Coquelin: On 9/14/22 03:05, Xia, Chenbo wrote: From: Maxime Coquelin On 7/26/22 09:55, Maxime Coquelin wrote: The bug this patch is fixing is bei

Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation

2022-09-14 Thread Thomas Monjalon
14/09/2022 11:34, Maxime Coquelin: > > On 9/14/22 11:15, Thomas Monjalon wrote: > > 14/09/2022 09:14, Maxime Coquelin: > >> On 9/14/22 03:05, Xia, Chenbo wrote: > >>> From: Maxime Coquelin > On 7/26/22 09:55, Maxime Coquelin wrote: > The bug this patch is fixing is being reproduced down

Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation

2022-09-14 Thread Maxime Coquelin
On 9/14/22 11:15, Thomas Monjalon wrote: 14/09/2022 09:14, Maxime Coquelin: On 9/14/22 03:05, Xia, Chenbo wrote: From: Maxime Coquelin On 7/26/22 09:55, Maxime Coquelin wrote: The bug this patch is fixing is being reproduced downstream. It would be great it gets merged in main branch rapid

Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation

2022-09-14 Thread Thomas Monjalon
14/09/2022 09:14, Maxime Coquelin: > On 9/14/22 03:05, Xia, Chenbo wrote: > > From: Maxime Coquelin > >> On 7/26/22 09:55, Maxime Coquelin wrote: > >> The bug this patch is fixing is being reproduced downstream. > >> It would be great it gets merged in main branch rapidly so that we can > >> perfo

Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation

2022-09-14 Thread Maxime Coquelin
Hi Chenbo, On 9/14/22 03:05, Xia, Chenbo wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Tuesday, September 13, 2022 11:03 PM To: David Marchand ; Xia, Chenbo ; Thomas Monjalon Cc: sta...@dpdk.org; dev@dpdk.org Subject: Re: [PATCH v3 1/4] vhost: fix vq use after

RE: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation

2022-09-13 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, September 13, 2022 11:03 PM > To: David Marchand ; Xia, Chenbo > ; Thomas Monjalon > Cc: sta...@dpdk.org; dev@dpdk.org > Subject: Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA &

Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation

2022-09-13 Thread Maxime Coquelin
Hi, On 7/26/22 09:55, Maxime Coquelin wrote: On 7/25/22 22:32, David Marchand wrote: translate_ring_addresses (via numa_realloc) may change a virtio device and virtio queue. The virtqueue object must be refreshed before accessing the lock. Fixes: 04c27cb673b9 ("vhost: fix unsafe vring addre

Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation

2022-07-26 Thread Maxime Coquelin
On 7/25/22 22:32, David Marchand wrote: translate_ring_addresses (via numa_realloc) may change a virtio device and virtio queue. The virtqueue object must be refreshed before accessing the lock. Fixes: 04c27cb673b9 ("vhost: fix unsafe vring addresses modifications") Cc: sta...@dpdk.org Signe