Re: [PATCH v3 1/4] dts: add send_packets to test suites and rework packet addressing

2024-08-29 Thread Nicholas Pratte
Hi Jeremy, sorry for the delay! See my comments below. > > > Assumptions: > > > Two links between SUT and TG, one link is TG -> SUT, the > > > other SUT -> TG. > > > > > > Args: > > > -packet: The packet to modify. > > > +packets: The packet

Re: [PATCH v3 1/4] dts: add send_packets to test suites and rework packet addressing

2024-07-26 Thread Jeremy Spewock
Thanks for the comments, I just had one clarifying question about them, but otherwise I will address them in the next version. On Fri, Jul 26, 2024 at 3:00 PM Nicholas Pratte wrote: > > I'll make sure to look over the other parts of this series and leave > reviews at some point next week, but I p

Re: [PATCH v3 1/4] dts: add send_packets to test suites and rework packet addressing

2024-07-26 Thread Nicholas Pratte
I'll make sure to look over the other parts of this series and leave reviews at some point next week, but I prioritized this since I will be using this patch at some point in my GRE suites. > diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py > index 694b2eba65..0b678ed62d 100

Re: [PATCH v3 1/4] dts: add send_packets to test suites and rework packet addressing

2024-07-26 Thread Nicholas Pratte
This is great, I'll be using this in-favor of the boolean solution that I implemented! Just to bring this to your attention. I am currently working on some Generic Routing Encapsulation suites the require multiple IP layers at packet creation; they look something like: Ether() / IP() / GRE() / IP(