Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-23 Thread Levend Sayar
Thanks Ferruh For applying. > On 23 Feb 2023, at 14:10, Ferruh Yigit wrote: > > On 2/23/2023 4:34 AM, Guo, Junfeng wrote: > > On 2/20/2023 9:11 PM, Levend Sayar wrote: >> rx no_mbufs stats counter update is added for another error case. >> >> Fixes: 4f6b1dd8240c ("net/gve: supp

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-23 Thread Ferruh Yigit
On 2/23/2023 4:34 AM, Guo, Junfeng wrote: On 2/20/2023 9:11 PM, Levend Sayar wrote: > rx no_mbufs stats counter update is added for another error case. > > Fixes: 4f6b1dd8240c ("net/gve: support basic statistics") > Cc: junfeng@intel.com > > Signed-off-by: Levend S

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-22 Thread Levend Sayar
ebruary 21, 2023 18:31 >> To: Levend Sayar mailto:levendsa...@gmail.com>> >> Cc: Guo, Junfeng mailto:junfeng@intel.com>>; >> dev@dpdk.org <mailto:dev@dpdk.org>; Stephen >> Hemminger mailto:step...@networkplumber.org>> >> Subject: Re: [PATCH v3 1/2

RE: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-22 Thread Guo, Junfeng
Acked-by: Junfeng Guo > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 21, 2023 18:31 > To: Levend Sayar > Cc: Guo, Junfeng ; dev@dpdk.org; Stephen > Hemminger > Subject: Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update >

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-21 Thread Levend Sayar
Thanks Ferruh for the heads up. It was a little confusion for me to decide what to do either. I will do as expected for future. I did not want to overwrite any commit that is already acked. So pushed new versions only for the ones needs recommits. Levend > On 21 Feb 2023, at 18:58, Ferruh Yig

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-21 Thread Ferruh Yigit
On 2/20/2023 9:11 PM, Levend Sayar wrote: > rx no_mbufs stats counter update is added for another error case. > > Fixes: 4f6b1dd8240c ("net/gve: support basic statistics") > Cc: junfeng@intel.com > > Signed-off-by: Levend Sayar Reviewed-by: Ferruh Yigit (No problem for this time, but for

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-21 Thread Ferruh Yigit
On 2/21/2023 10:07 AM, Levend Sayar wrote: > Not only this if, there can be many places to add such branch prediction > helpers > On the gve pmd code. > > I preferred to patch only the bug here and not used unlikely to minimize > noise. > > Imho, adding likely/unlikely to all gve pmd code can

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-21 Thread Levend Sayar
Not only this if, there can be many places to add such branch prediction helpers On the gve pmd code. I preferred to patch only the bug here and not used unlikely to minimize noise. Imho, adding likely/unlikely to all gve pmd code can be topic of another patch maybe. Levend > On 21 Feb 2023,

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-20 Thread Ferruh Yigit
On 2/20/2023 9:11 PM, Levend Sayar wrote: > rx no_mbufs stats counter update is added for another error case. > > Fixes: 4f6b1dd8240c ("net/gve: support basic statistics") > Cc: junfeng@intel.com > > Signed-off-by: Levend Sayar > --- > drivers/net/gve/gve_rx.c | 5 - > 1 file changed, 4