RE: [PATCH v3 1/1] ethdev: mtr: support input color selection

2022-04-11 Thread Ori Kam
; Jerin Jacob ; > sk...@marvell.com; Ori > Kam > Subject: RE: [PATCH v3 1/1] ethdev: mtr: support input color selection > > Hi folks, > > Thanks to the community colleagues that participated to the call earlier > today. Apologies for not CC-ing > all the 9 attendants, a

RE: [PATCH v3 1/1] ethdev: mtr: support input color selection

2022-04-11 Thread Dumitrescu, Cristian
Hi folks, Thanks to the community colleagues that participated to the call earlier today. Apologies for not CC-ing all the 9 attendants, as I don't have the email address for all of them. We had a good meeting, I think we agreed on a good solution that will also simplify the API proposal. Rec

Re: [PATCH v3 1/1] ethdev: mtr: support input color selection

2022-04-07 Thread Jerin Jacob
On Thu, Apr 7, 2022 at 6:55 PM Dumitrescu, Cristian wrote: > > > > > To summarize we have 4 attributes, Please find below the truth table > > 1) Outer VLAN > > 2) Outer IP > > 3) Inner VLAN > > 4) Inner IP > > > > > > Inner IP -Inner VLAN- Outer IP-Outer VLAN > > 00

RE: [PATCH v3 1/1] ethdev: mtr: support input color selection

2022-04-07 Thread Dumitrescu, Cristian
> > To summarize we have 4 attributes, Please find below the truth table > 1) Outer VLAN > 2) Outer IP > 3) Inner VLAN > 4) Inner IP > > > Inner IP -Inner VLAN- Outer IP-Outer VLAN > 00 0 0 > - Not valid case > 00 0

Re: [PATCH v3 1/1] ethdev: mtr: support input color selection

2022-04-07 Thread Jerin Jacob
00 0 0 00 0 0 On Tue, Mar 1, 2022 at 11:18 PM Dumitrescu, Cristian wrote: > > HI Jerin, Hi Cristian, > > Thanks for your patch! I think we are making great progress, here are a few > more commen

RE: [PATCH v3 1/1] ethdev: mtr: support input color selection

2022-04-05 Thread Dumitrescu, Cristian
erin Jacob > Subject: RE: [PATCH v3 1/1] ethdev: mtr: support input color selection > > HI Jerin, > > Thanks for your patch! I think we are making great progress, here are a few > more comments: > > > > > +/** > > + * Input color method > > + */

RE: [PATCH v3 1/1] ethdev: mtr: support input color selection

2022-03-01 Thread Dumitrescu, Cristian
HI Jerin, Thanks for your patch! I think we are making great progress, here are a few more comments: > +/** > + * Input color method > + */ > +enum rte_mtr_input_color_method { We should clean up the names of these methods a bit: we should not mix header names (VLAN, IP) with header field n