Re: [PATCH v3] log: add timestamp for log

2023-03-06 Thread Stephen Hemminger
On Mon, 6 Mar 2023 13:00:17 -0800 Tyler Retzlaff wrote: > On Sat, Mar 04, 2023 at 08:04:41AM -0800, Stephen Hemminger wrote: > > On Sat, 4 Mar 2023 16:14:21 +0800 > > luzhipeng wrote: > > > > > From: Zhipeng Lu > > > > > > add timestamp for log > > > > > > Signed-off-by: Zhipeng Lu > >

Re: [PATCH v3] log: add timestamp for log

2023-03-06 Thread Tyler Retzlaff
On Sat, Mar 04, 2023 at 08:04:41AM -0800, Stephen Hemminger wrote: > On Sat, 4 Mar 2023 16:14:21 +0800 > luzhipeng wrote: > > > From: Zhipeng Lu > > > > add timestamp for log > > > > Signed-off-by: Zhipeng Lu > > Good idea but: > - it needs to be optional > - timestamp only makes sense

Re: [PATCH v3] log: add timestamp for log

2023-03-04 Thread Stephen Hemminger
On Sat, 4 Mar 2023 16:14:21 +0800 luzhipeng wrote: > From: Zhipeng Lu > > add timestamp for log > > Signed-off-by: Zhipeng Lu Good idea but: - it needs to be optional - timestamp only makes sense on the terminal (stdout) log stream syslog/journal already have timestamp I did a sim