Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-07-08 Thread Damodharam Ammepalli
On Fri, Jul 5, 2024 at 10:33 AM Ferruh Yigit wrote: > > On 6/26/2024 3:19 AM, huangdengdui wrote: > > > > On 2024/6/26 5:07, Damodharam Ammepalli wrote: > >> On Wed, Jun 19, 2024 at 8:23 PM huangdengdui > >> wrote: > >>> > >>> Hi Damodharam > >>> Here are some suggestions. See below. > >>> > >>

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-07-08 Thread Damodharam Ammepalli
On Fri, Jul 5, 2024 at 10:35 AM Ferruh Yigit wrote: > > On 6/17/2024 9:34 PM, Damodharam Ammepalli wrote: > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change, or be removed, without prior > > notice > > + * > > + * Set speed lanes supported by the NIC. > > + * > > + * @param po

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-07-05 Thread Ferruh Yigit
On 6/17/2024 9:34 PM, Damodharam Ammepalli wrote: > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Set speed lanes supported by the NIC. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param speed

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-07-05 Thread Ferruh Yigit
On 6/26/2024 3:19 AM, huangdengdui wrote: > > On 2024/6/26 5:07, Damodharam Ammepalli wrote: >> On Wed, Jun 19, 2024 at 8:23 PM huangdengdui wrote: >>> >>> Hi Damodharam >>> Here are some suggestions. See below. >>> >> Thank you for the review. >> >>> On 2024/6/18 4:34, Damodharam Ammepalli wrote

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-06-25 Thread huangdengdui
On 2024/6/26 5:07, Damodharam Ammepalli wrote: > On Wed, Jun 19, 2024 at 8:23 PM huangdengdui wrote: >> >> Hi Damodharam >> Here are some suggestions. See below. >> > Thank you for the review. > >> On 2024/6/18 4:34, Damodharam Ammepalli wrote: >>> Update the eth_dev_ops structure with new func

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-06-25 Thread Damodharam Ammepalli
On Wed, Jun 19, 2024 at 8:23 PM huangdengdui wrote: > > Hi Damodharam > Here are some suggestions. See below. > Thank you for the review. > On 2024/6/18 4:34, Damodharam Ammepalli wrote: > > Update the eth_dev_ops structure with new function vectors > > to get, get capabilities and set ethernet l

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-06-19 Thread huangdengdui
Hi Damodharam Here are some suggestions. See below. On 2024/6/18 4:34, Damodharam Ammepalli wrote: > Update the eth_dev_ops structure with new function vectors > to get, get capabilities and set ethernet link speed lanes. > Update the testpmd to provide required config and information > display in