Re: [PATCH v3] build: select optional libraries

2023-06-22 Thread Juraj Linkeš
On Wed, Jun 21, 2023 at 11:54 AM David Marchand wrote: > On Tue, Jun 20, 2023 at 5:05 PM Bruce Richardson > wrote: > > > > On Tue, Jun 20, 2023 at 04:33:15PM +0200, Thomas Monjalon wrote: > > > 20/06/2023 11:03, Bruce Richardson: > > > > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand w

RE: [PATCH v3] build: select optional libraries

2023-06-21 Thread Morten Brørup
I haven't followed this discussion in detail, so this might have been mentioned already... Omitting deprecated libs when building will not omit deprecated functions in other libs. In other words: Omitting deprecated libs only achieves part of what we really want to achieve (omitting everything

Re: [PATCH v3] build: select optional libraries

2023-06-21 Thread Bruce Richardson
On Wed, Jun 21, 2023 at 11:54:31AM +0200, David Marchand wrote: > On Tue, Jun 20, 2023 at 5:05 PM Bruce Richardson > wrote: > > > > On Tue, Jun 20, 2023 at 04:33:15PM +0200, Thomas Monjalon wrote: > > > 20/06/2023 11:03, Bruce Richardson: > > > > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Mar

Re: [PATCH v3] build: select optional libraries

2023-06-21 Thread David Marchand
On Tue, Jun 20, 2023 at 5:05 PM Bruce Richardson wrote: > > On Tue, Jun 20, 2023 at 04:33:15PM +0200, Thomas Monjalon wrote: > > 20/06/2023 11:03, Bruce Richardson: > > > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > > > > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > > >

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Bruce Richardson
On Tue, Jun 20, 2023 at 04:33:15PM +0200, Thomas Monjalon wrote: > 20/06/2023 11:03, Bruce Richardson: > > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > > > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > > > wrote: > > > > > > > > I notice the change in behaviour for enabl

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Bruce Richardson
On Tue, Jun 20, 2023 at 04:33:15PM +0200, Thomas Monjalon wrote: > 20/06/2023 11:03, Bruce Richardson: > > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > > > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > > > wrote: > > > > > > > > I notice the change in behaviour for enabl

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Thomas Monjalon
20/06/2023 11:03, Bruce Richardson: > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > > wrote: > > > > > > > I notice the change in behaviour for enabling the deprecated > > > > > > > libs. Is there > > > > > > > any other ch

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Bruce Richardson
On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > wrote: > > > > > > I notice the change in behaviour for enabling the deprecated libs. > > > > > > Is there > > > > > > any other change in behaviour for current users? > > > > > >

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson wrote: > > > > > I notice the change in behaviour for enabling the deprecated libs. Is > > > > > there > > > > > any other change in behaviour for current users? > > > > > > > > The only change I see, is that this implementation breaks enabling >

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Bruce Richardson
On Tue, Jun 20, 2023 at 10:38:33AM +0200, David Marchand wrote: > On Tue, Jun 20, 2023 at 10:36 AM Bruce Richardson > wrote: > > On Tue, Jun 20, 2023 at 10:31:19AM +0200, David Marchand wrote: > > > On Mon, Jun 19, 2023 at 4:26 PM Bruce Richardson > > > wrote: > > > > > > > > On Mon, Jun 19, 2023

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 10:36 AM Bruce Richardson wrote: > On Tue, Jun 20, 2023 at 10:31:19AM +0200, David Marchand wrote: > > On Mon, Jun 19, 2023 at 4:26 PM Bruce Richardson > > wrote: > > > > > > On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > > > > On Fri, Jun 16, 2023 at 9:

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Bruce Richardson
On Tue, Jun 20, 2023 at 10:31:19AM +0200, David Marchand wrote: > On Mon, Jun 19, 2023 at 4:26 PM Bruce Richardson > wrote: > > > > On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > > > On Fri, Jun 16, 2023 at 9:21 AM David Marchand > > > wrote: > > > > @@ -141,13 +137,25 @@ forea

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread David Marchand
On Mon, Jun 19, 2023 at 4:26 PM Bruce Richardson wrote: > > On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > > On Fri, Jun 16, 2023 at 9:21 AM David Marchand > > wrote: > > > @@ -141,13 +137,25 @@ foreach l:libraries > > > deps += ['eal'] > > > endif > > > > > > -

Re: [PATCH v3] build: select optional libraries

2023-06-19 Thread Bruce Richardson
On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > On Fri, Jun 16, 2023 at 9:21 AM David Marchand > wrote: > > @@ -141,13 +137,25 @@ foreach l:libraries > > deps += ['eal'] > > endif > > > > -if disabled_libs.contains(l) > > +if not enable_libs.contains(l) > >

Re: [PATCH v3] build: select optional libraries

2023-06-19 Thread David Marchand
On Fri, Jun 16, 2023 at 9:21 AM David Marchand wrote: > @@ -141,13 +137,25 @@ foreach l:libraries > deps += ['eal'] > endif > > -if disabled_libs.contains(l) > +if not enable_libs.contains(l) > +build = false > +reason = 'not in enabled libraries build config'

Re: [PATCH v3] build: select optional libraries

2023-06-19 Thread David Marchand
On Fri, Jun 16, 2023 at 11:42 AM Bruce Richardson wrote: > On Fri, Jun 16, 2023 at 09:14:50AM +0200, David Marchand wrote: > > There is currently no way to know which libraries are optional. > > Introduce a enable_libs option (close to what we have for drivers) so > > that packagers or projects co

Re: [PATCH v3] build: select optional libraries

2023-06-16 Thread Bruce Richardson
On Fri, Jun 16, 2023 at 09:14:50AM +0200, David Marchand wrote: > There is currently no way to know which libraries are optional. > Introduce a enable_libs option (close to what we have for drivers) so > that packagers or projects consuming DPDK can more easily select the > optional libraries that