Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-10-06 Thread Ferruh Yigit
On 10/6/2023 9:27 AM, David Marchand wrote: > On Fri, Aug 11, 2023 at 8:08 AM Sivaprasad Tummala > wrote: >> >> This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU >> features without breaking ABI each time. >> >> Signed-off-by: Sivaprasad Tummala > > I relooked at the API and I see one cas

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-10-06 Thread David Marchand
On Fri, Aug 11, 2023 at 8:08 AM Sivaprasad Tummala wrote: > > This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU > features without breaking ABI each time. > > Signed-off-by: Sivaprasad Tummala I relooked at the API and I see one case (that I had missed in my previous reply) where an ABI i

RE: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-28 Thread Tummala, Sivaprasad
konstantin.v.anan...@yandex.ru > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration > > On 8/11/2023 7:07 AM, Sivaprasad Tummala wrote: > > This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU features > > without breaking ABI each time.

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-27 Thread Ferruh Yigit
son > >>>     > <mailto:bruce.richard...@intel.com> > <mailto:bruce.richard...@intel.com > <mailto:bruce.richard...@intel.com>>>; > >>>     Konstantin Ananyev > >>>     > <mailto:konstantin.v.anan...@yandex.ru&g

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-27 Thread Stanisław Kardach
ichardson > >>> > mailto:bruce.richard...@intel.com > >>; > >>> Konstantin Ananyev > >>> > >>> <mailto:konstantin.v.anan...@yandex.ru>>; dev >>> <mailto:dev@dpdk.org>>; Yigit, Ferruh > >>&

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-27 Thread Ferruh Yigit
<mailto:zhou...@loongson.cn>>; >>> > David Christensen >> <mailto:d...@linux.vnet.ibm.com>>; Bruce Richardson >>> > mailto:bruce.richard...@intel.com>>; >>> Konstantin Ananyev >>> > >> <mailto:konstantin

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-27 Thread Stanisław Kardach
.ibm.com>>; Bruce Richardson > > > mailto:bruce.richard...@intel.com>>; > > Konstantin Ananyev > > > > <mailto:konstantin.v.anan...@yandex.ru>>; dev > <mailto:dev@dpdk.org>>; Yigit, Ferruh > > > mailto:ferruh.yi.

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-27 Thread Ferruh Yigit
On 8/11/2023 7:07 AM, Sivaprasad Tummala wrote: > This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU > features without breaking ABI each time. > > Signed-off-by: Sivaprasad Tummala > --- > lib/eal/arm/include/rte_cpuflags_32.h| 1 - > lib/eal/arm/include/rte_cpuflags_64.h| 1 - >

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-27 Thread Ferruh Yigit
stantin.v.anan...@yandex.ru>>; dev <mailto:dev@dpdk.org>>; Yigit, Ferruh > > mailto:ferruh.yi...@amd.com>>; Thomas > Monjalon mailto:tho...@monjalon.net>> > > Subject: Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration > > >

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-21 Thread Stanisław Kardach
t; Cc: Ruifeng Wang ; Min Zhou ; > > David Christensen ; Bruce Richardson > > ; Konstantin Ananyev > > ; dev ; Yigit, Ferruh > > ; Thomas Monjalon > > Subject: Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration > > > > Caution: This message originated from a

RE: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-21 Thread Tummala, Sivaprasad
Ananyev > ; dev ; Yigit, Ferruh > ; Thomas Monjalon > Subject: Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On We

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-20 Thread David Marchand
On Wed, Sep 20, 2023 at 8:01 AM Stanisław Kardach wrote: > > On Tue, Sep 19, 2023 at 4:47 PM David Marchand > wrote: > > > > Also I see you're still removing the RTE_CPUFLAG_NUMFLAGS (what I call a > > > last element canary). Why? If you're concerned with ABI, then we're > > > talking about a

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-19 Thread Stanisław Kardach
On Tue, Sep 19, 2023 at 4:47 PM David Marchand wrote: > > Also I see you're still removing the RTE_CPUFLAG_NUMFLAGS (what I call a last element canary). Why? If you're concerned with ABI, then we're talking about an application linking dynamically with DPDK or talking via some RPC channel with an

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-09-19 Thread David Marchand
Hello, On Tue, Aug 15, 2023 at 8:10 AM Stanisław Kardach wrote: > On Fri, Aug 11, 2023, 08:08 Sivaprasad Tummala > wrote: >> diff --git a/lib/eal/arm/include/rte_cpuflags_32.h >> b/lib/eal/arm/include/rte_cpuflags_32.h >> index 4e254428a2..41ab0d5f21 100644 >> --- a/lib/eal/arm/include/rte_cpu

Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-08-14 Thread Stanisław Kardach
On Fri, Aug 11, 2023, 08:08 Sivaprasad Tummala wrote: > This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU > features without breaking ABI each time. > > Signed-off-by: Sivaprasad Tummala > --- > lib/eal/arm/include/rte_cpuflags_32.h| 1 - > lib/eal/arm/include/rte_cpuflags_64.h|