Re: [PATCH v2] eal/unix: support ZSTD compression for firmware

2024-07-03 Thread Xueming Li
Thanks, I tried but missed the "EAL" part :-) From: David Marchand Sent: Wednesday, July 3, 2024 3:27 PM To: Xueming Li Cc: dev@dpdk.org ; Yu Jiang ; Bruce Richardson ; sta...@dpdk.org Subject: Re: [PATCH v2] eal/unix: support ZSTD compression for fi

Re: [PATCH v2] eal/unix: support ZSTD compression for firmware

2024-07-03 Thread David Marchand
On Wed, Jul 3, 2024 at 9:12 AM Xueming Li wrote: > > Hi David, > > I get unix compilation failure when backporting this patch to 23.11 LTS, the > EAL_LOG macro is not backported to 23.11 LTS, any suggestion? Like other logging calls in this same file, you can replace EAL_LOG(level, fmt, args); w

Re: [PATCH v2] eal/unix: support ZSTD compression for firmware

2024-07-03 Thread Xueming Li
Hi David, I get unix compilation failure when backporting this patch to 23.11 LTS, the EAL_LOG macro is not backported to 23.11 LTS, any suggestion? Regards, Xueming From: David Marchand Sent: Monday, May 13, 2024 7:12 PM To: dev@dpdk.org Cc: Yu Jiang ; Bruce

Re: [PATCH v2] eal/unix: support ZSTD compression for firmware

2024-05-17 Thread David Marchand
On Mon, May 13, 2024 at 1:37 PM Bruce Richardson wrote: > On Mon, May 13, 2024 at 01:12:04PM +0200, David Marchand wrote: > > Ubuntu 24.04 started to compress firmware files with ZSTD compression. > > > > Bugzilla ID: 1437 > > Cc: sta...@dpdk.org > > > > Signed-off-by: David Marchand > Acked-by:

Re: [PATCH v2] eal/unix: support ZSTD compression for firmware

2024-05-13 Thread David Marchand
Hello Bruce, On Mon, May 13, 2024 at 1:37 PM Bruce Richardson wrote: > > @@ -16,6 +16,8 @@ > > #include "eal_firmware.h" > > #include "eal_private.h" > > > > +static const char * const compression_algorithms[] = { "xz", "zst" }; > Very minor nit: these are the suffixes used to find the files, m

Re: [PATCH v2] eal/unix: support ZSTD compression for firmware

2024-05-13 Thread Bruce Richardson
On Mon, May 13, 2024 at 01:12:04PM +0200, David Marchand wrote: > Ubuntu 24.04 started to compress firmware files with ZSTD compression. > > Bugzilla ID: 1437 > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- > Chances since v1: > - fixed link issue when libarchive is not available,