Re: [PATCH v2] dts: add VLAN methods to testpmd shell

2024-09-24 Thread Juraj Linkeš
We should bring up the exact names of method used in this patch and talk through them in the call. On 18. 9. 2024 21:41, Dean Marx wrote: added the following methods to testpmd shell class: Capitalize please. vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, tx vlan set/reset,

Re: [PATCH v2] dts: add VLAN methods to testpmd shell

2024-09-20 Thread Jeremy Spewock
On Wed, Sep 18, 2024 at 3:41 PM Dean Marx wrote: > > + > +def tx_vlan_set(self, port: int, vlan: int, verify: bool = True) -> None: One thing to note is that I think this method (unlike rx_vlan_set for some reason) requires the ports to be stopped for it to work, so we should probably decora