Re: [PATCH v1 2/3] dts: add dual_vlan testing suite

On Thu, Jul 25, 2024 at 9:56 AM Jeremy Spewock wrote: > > On Mon, Jul 22, 2024 at 1:38 PM Dean Marx wrote: > >> > >> > >> +recv = self.send_packet_and_capture(pakt) > >> +self.verify(len(recv) > 0, "Did not receive and packets when > >> testing VLAN priority.") > > > > > > I'm a

Re: [PATCH v1 2/3] dts: add dual_vlan testing suite

On Mon, Jul 22, 2024 at 1:38 PM Dean Marx wrote: >> >> >> +recv = self.send_packet_and_capture(pakt) >> +self.verify(len(recv) > 0, "Did not receive and packets when >> testing VLAN priority.") > > > I'm assuming this should say "any" instead of "and." Other than that, > everyth

Re: [PATCH v1 2/3] dts: add dual_vlan testing suite

> > > +recv = self.send_packet_and_capture(pakt) > +self.verify(len(recv) > 0, "Did not receive and packets when > testing VLAN priority.") > I'm assuming this should say "any" instead of "and." Other than that, everything looks good to me. Reviewed-by: Dean Marx