RE: [PATCH dpdk v1 00/15] IPv6 APIs overhaul

2024-08-22 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > > Morten Brørup, Aug 22, 2024 at 17:13: > > Maybe the 'a' field in the DPDK IPv6 address structure should be named > 'b' for "byte" instead, to prepare it for adding a union with a 'w' (for > "word") field if we want to introduce 2-byte alignment.

Re: [PATCH dpdk v1 00/15] IPv6 APIs overhaul

2024-08-22 Thread Robin Jarry
Morten Brørup, Aug 22, 2024 at 17:13: The types seem to be different in the Windows API (than in Linux/BSD): https://github.com/tpn/winsdk-10/blob/9b69fd26ac0c7d0b83d378dba01080e93349c2ed/Include/10.0.14393.0/shared/in6addr.h#L25 https://github.com/tpn/winsdk-10/blob/9b69fd26ac0c7d0b83d378dba0108

Re: [PATCH dpdk v1 00/15] IPv6 APIs overhaul

2024-08-22 Thread Robin Jarry
Stephen Hemminger, Aug 22, 2024 at 16:13: Why does DPDK need to have its own definitions of IPv4 and IPv6 addresses? The structures in_addr and in6_addr exist on Linux, BSD, and Windows. It creates lots of code reimplementation (see inet_ntop etc). By the way, you can call inet_ntop(AF_INET6) w

Re: [PATCH dpdk v1 00/15] IPv6 APIs overhaul

2024-08-22 Thread Robin Jarry
Stephen Hemminger, Aug 22, 2024 at 16:13: Let me ask a couple of questions about this. Why does DPDK need to have its own definitions of IPv4 and IPv6 addresses? The structures in_addr and in6_addr exist on Linux, BSD, and Windows. It creates lots of code reimplementation (see inet_ntop etc). W

RE: [PATCH dpdk v1 00/15] IPv6 APIs overhaul

2024-08-22 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > > On Wed, 21 Aug 2024 18:25:17 +0200 > Robin Jarry wrote: > > > Hi everyone, > > > > As discussed recently [1], here is a first draft of the IPv6 APIs rework. > The > > API change was announced before the 24.07 release [2]. This ser

RE: [PATCH dpdk v1 00/15] IPv6 APIs overhaul

2024-08-21 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Wednesday, 21 August 2024 18.25 > > Hi everyone, > > As discussed recently [1], here is a first draft of the IPv6 APIs > rework. The > API change was announced before the 24.07 release [2]. This series is > intended > for 24.11. > > [1] http