Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-11-04 Thread Nicholas Pratte
Noted, I appreciate the insight! On Tue, Oct 29, 2024 at 8:56 AM Luca Vizzarro wrote: > > On 01/10/2024 21:45, Nicholas Pratte wrote: > > The code you have here makes sense, and I like the implementation as > > it removes a lot of fluff in DTSRunner. I know Jurja mentioned in an > > earlier patch

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-10-29 Thread Luca Vizzarro
On 17/09/2024 12:39, Juraj Linkeš wrote: @@ -229,139 +221,34 @@ def _get_test_suites_with_cases( +    filtered_test_cases: list[TestCase] = [ +    test_case +    for test_case in test_suite_spec.test_cases +    if not test_suite_config.test_cases_nam

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-10-29 Thread Luca Vizzarro
On 01/10/2024 21:45, Nicholas Pratte wrote: The code you have here makes sense, and I like the implementation as it removes a lot of fluff in DTSRunner. I know Jurja mentioned in an earlier patch in this series that this functionality intersects with the capabilities series, but I'm missing a lot

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-10-29 Thread Luca Vizzarro
On 01/10/2024 18:12, Dean Marx wrote: +            filtered_test_cases: list[TestCase] = [ +                test_case +                for test_case in test_suite_spec.test_cases +                if not test_suite_config.test_cases_names +                or test_case.name

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-10-01 Thread Nicholas Pratte
The code you have here makes sense, and I like the implementation as it removes a lot of fluff in DTSRunner. I know Jurja mentioned in an earlier patch in this series that this functionality intersects with the capabilities series, but I'm missing a lot of context to understand that fully. Maybe yo

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-10-01 Thread Dean Marx
On Thu, Aug 22, 2024 at 12:40 PM Luca Vizzarro wrote: > The introduction of TestSuiteSpec adds auto-discovery of test suites, > which are also automatically imported. This causes double imports as the > runner loads the test suites. This changes the behaviour of the runner > to load the imported

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-09-17 Thread Juraj Linkeš
diff --git a/dts/framework/runner.py b/dts/framework/runner.py @@ -229,139 +221,34 @@ def _get_test_suites_with_cases( +filtered_test_cases: list[TestCase] = [ +test_case +for test_case in test_suite_spec.test_cases +if not test_