Re: [PATCH] net/r8169: add support for hw initialization

2024-09-25 Thread Stephen Hemminger
On Wed, 25 Sep 2024 15:54:21 +0800 Howard Wang wrote: > static int > rtl_dev_close(struct rte_eth_dev *dev) > { > + //struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev); > + //struct rte_intr_handle *intr_handle = pci_dev->intr_handle; No commented out code please. As checkpatch

Re: [PATCH] net/r8169: add support for hw initialization

2024-09-25 Thread Stephen Hemminger
On Wed, 25 Sep 2024 15:54:21 +0800 Howard Wang wrote: > + PMD_INIT_LOG(NOTICE, "r8169: Assign randomly generated MAC > address " > + "%02x:%02x:%02x:%02x:%02x:%02x", > + perm_addr->addr_bytes[0], > + perm_addr

Re: [PATCH] net/r8169: add support for hw initialization

2024-09-25 Thread Stephen Hemminger
On Wed, 25 Sep 2024 15:54:21 +0800 Howard Wang wrote: > From: Howard Wang > To: > CC: , Howard Wang > Subject: [PATCH] net/r8169: add support for hw initialization > Date: Wed, 25 Sep 2024 15:54:21 +0800 > X-Mailer: git-send-email 2.34.1 > > Signed-off-by: Howard Wang Please use git-send-em