Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-23 Thread Khadem Ullah
This patch is a logical continuation of the commit: ``` commit 30410493759f ("drivers/net: check process type in close operation") ``` In that change, @Thomas Monjalon introduced a mechanism to prevent secondary processes from incorrectly releasing shared resources during device close operation

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-22 Thread Khadem Ullah
I think at least this should be followed either in PMD or in ethdev layer to avoid this specific crashes. On Mon, Jul 21, 2025, 17:00 Thomas Monjalon wrote: > 21/07/2025 13:46, Ivan Malov: > > On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: > > > > > + mlx5 maintainers > > > > > > Thank you for th

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-22 Thread Khadem Ullah
Hi Ivan, Thanks for the detailed explanation. While primary termination is a known limitation, I believe the application or PMD should handle edge cases proactively to ensure stability. On Tue, Jul 22, 2025 at 9:26 PM Ivan Malov wrote: > Hi Dariusz, Khadem, > > On Mon, 21 Jul 2025, Dariusz Sos

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-22 Thread Ivan Malov
Hi Dariusz, Khadem, On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: On Mon, Jul 21, 2025 at 01:59:59PM +0200, Thomas Monjalon wrote: 21/07/2025 13:46, Ivan Malov: On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: + mlx5 maintainers Thank you for the patch. Could you please include other PMD mai

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Stephen Hemminger
On Mon, 21 Jul 2025 12:58:19 +0200 Dariusz Sosnowski wrote: > I don't think it's an issue on PMD level, but rather on > ethdev/multi-process handling level. > > When primary process closes the port, ethdev library zeroes and frees > device data shared between processes. > ethdev port data (rte_e

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Dariusz Sosnowski
On Mon, Jul 21, 2025 at 01:59:59PM +0200, Thomas Monjalon wrote: > 21/07/2025 13:46, Ivan Malov: > > On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: > > > > > + mlx5 maintainers > > > > > > Thank you for the patch. > > > > > > Could you please include other PMD maintainers (or other maintainers, >

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Thomas Monjalon
21/07/2025 13:46, Ivan Malov: > On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: > > > + mlx5 maintainers > > > > Thank you for the patch. > > > > Could you please include other PMD maintainers (or other maintainers, > > depending on changed code) > > in the future patches? > > There is a script whi

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Ivan Malov
On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: + mlx5 maintainers Thank you for the patch. Could you please include other PMD maintainers (or other maintainers, depending on changed code) in the future patches? There is a script which automatically adds maintainers while sending a patch. It is

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Dariusz Sosnowski
+ mlx5 maintainers Thank you for the patch. Could you please include other PMD maintainers (or other maintainers, depending on changed code) in the future patches? There is a script which automatically adds maintainers while sending a patch. It is described in: https://doc.dpdk.org/guides/contr