Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 6/3/24 05:33, Stephen Hemminger wrote: On Mon, 3 Jun 2024 09:38:19 +0800 Jie Hai wrote: On 2024/3/1 19:10, Ferruh Yigit wrote: On 3/1/2024 6:55 AM, huangdengdui wrote: On 2024/2/29 17:25, Ferruh Yigit wrote: On 2/29/2024 3:58 AM, huangdengdui wrote: On 2024/2/28 21:07, Ferruh Yigit

RE: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

> IMHO the only sane thing is: > -if keep crc is enabled then pkt_len and data_len include the extra > bytes for the CRC. Agree. Consider a segmented packet where only the CRC is in the last segment. The length of that last segment would be zero if the CRC length was not included in pkt_len and

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On Mon, 3 Jun 2024 09:38:19 +0800 Jie Hai wrote: > On 2024/3/1 19:10, Ferruh Yigit wrote: > > On 3/1/2024 6:55 AM, huangdengdui wrote: > >> > >> > >> On 2024/2/29 17:25, Ferruh Yigit wrote: > >>> On 2/29/2024 3:58 AM, huangdengdui wrote: > > > On 2024/2/28 21:07, Ferruh Yigit

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2024/3/1 19:10, Ferruh Yigit wrote: On 3/1/2024 6:55 AM, huangdengdui wrote: On 2024/2/29 17:25, Ferruh Yigit wrote: On 2/29/2024 3:58 AM, huangdengdui wrote: On 2024/2/28 21:07, Ferruh Yigit wrote: On 2/28/2024 2:27 AM, huangdengdui wrote: On 2024/2/27 0:43, Ferruh Yigit wrote: On

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

Hi, Ferruh Kindly ping for reply. Thanks, Jie Hai On 2024/3/8 19:36, Jie Hai wrote: On 2024/3/1 19:10, Ferruh Yigit wrote: On 3/1/2024 6:55 AM, huangdengdui wrote: On 2024/2/29 17:25, Ferruh Yigit wrote: On 2/29/2024 3:58 AM, huangdengdui wrote: On 2024/2/28 21:07, Ferruh Yigit wrote:

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2024/3/1 19:10, Ferruh Yigit wrote: On 3/1/2024 6:55 AM, huangdengdui wrote: On 2024/2/29 17:25, Ferruh Yigit wrote: On 2/29/2024 3:58 AM, huangdengdui wrote: On 2024/2/28 21:07, Ferruh Yigit wrote: On 2/28/2024 2:27 AM, huangdengdui wrote: On 2024/2/27 0:43, Ferruh Yigit wrote: On

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 3/1/2024 6:55 AM, huangdengdui wrote: > > > On 2024/2/29 17:25, Ferruh Yigit wrote: >> On 2/29/2024 3:58 AM, huangdengdui wrote: >>> >>> >>> On 2024/2/28 21:07, Ferruh Yigit wrote: On 2/28/2024 2:27 AM, huangdengdui wrote: > > > On 2024/2/27 0:43, Ferruh Yigit wrote: >> On

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2024/2/29 17:25, Ferruh Yigit wrote: > On 2/29/2024 3:58 AM, huangdengdui wrote: >> >> >> On 2024/2/28 21:07, Ferruh Yigit wrote: >>> On 2/28/2024 2:27 AM, huangdengdui wrote: On 2024/2/27 0:43, Ferruh Yigit wrote: > On 2/26/2024 3:16 AM, Jie Hai wrote: >> On 2024/2/23

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2/29/2024 3:58 AM, huangdengdui wrote: > > > On 2024/2/28 21:07, Ferruh Yigit wrote: >> On 2/28/2024 2:27 AM, huangdengdui wrote: >>> >>> >>> On 2024/2/27 0:43, Ferruh Yigit wrote: On 2/26/2024 3:16 AM, Jie Hai wrote: > On 2024/2/23 21:53, Ferruh Yigit wrote: >> On 2/20/2024 3:58

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2024/2/28 21:07, Ferruh Yigit wrote: > On 2/28/2024 2:27 AM, huangdengdui wrote: >> >> >> On 2024/2/27 0:43, Ferruh Yigit wrote: >>> On 2/26/2024 3:16 AM, Jie Hai wrote: On 2024/2/23 21:53, Ferruh Yigit wrote: > On 2/20/2024 3:58 AM, Jie Hai wrote: >> Hi, Ferruh, >> >> Th

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2/28/2024 2:27 AM, huangdengdui wrote: > > > On 2024/2/27 0:43, Ferruh Yigit wrote: >> On 2/26/2024 3:16 AM, Jie Hai wrote: >>> On 2024/2/23 21:53, Ferruh Yigit wrote: On 2/20/2024 3:58 AM, Jie Hai wrote: > Hi, Ferruh, > > Thanks for your review. > > On 2024/2/7 22:15,

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2024/2/27 0:43, Ferruh Yigit wrote: > On 2/26/2024 3:16 AM, Jie Hai wrote: >> On 2024/2/23 21:53, Ferruh Yigit wrote: >>> On 2/20/2024 3:58 AM, Jie Hai wrote: Hi, Ferruh, Thanks for your review. On 2024/2/7 22:15, Ferruh Yigit wrote: > On 2/6/2024 1:10 AM, Jie Hai

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2/26/2024 3:16 AM, Jie Hai wrote: > On 2024/2/23 21:53, Ferruh Yigit wrote: >> On 2/20/2024 3:58 AM, Jie Hai wrote: >>> Hi, Ferruh, >>> >>> Thanks for your review. >>> >>> On 2024/2/7 22:15, Ferruh Yigit wrote: On 2/6/2024 1:10 AM, Jie Hai wrote: > From: Dengdui Huang > > When

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2024/2/23 21:53, Ferruh Yigit wrote: On 2/20/2024 3:58 AM, Jie Hai wrote: Hi, Ferruh, Thanks for your review. On 2024/2/7 22:15, Ferruh Yigit wrote: On 2/6/2024 1:10 AM, Jie Hai wrote: From: Dengdui Huang When KEEP_CRC offload is enabled, some packets will be truncated and the CRC is st

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2/20/2024 3:58 AM, Jie Hai wrote: > Hi, Ferruh, > > Thanks for your review. > > On 2024/2/7 22:15, Ferruh Yigit wrote: >> On 2/6/2024 1:10 AM, Jie Hai wrote: >>> From: Dengdui Huang >>> >>> When KEEP_CRC offload is enabled, some packets will be truncated and >>> the CRC is still be stripped i

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

Hi, Ferruh, Thanks for your review. On 2024/2/7 22:15, Ferruh Yigit wrote: On 2/6/2024 1:10 AM, Jie Hai wrote: From: Dengdui Huang When KEEP_CRC offload is enabled, some packets will be truncated and the CRC is still be stripped in following cases: 1. For HIP08 hardware, the packet type is T

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2/6/2024 1:10 AM, Jie Hai wrote: > From: Dengdui Huang > > When KEEP_CRC offload is enabled, some packets will be truncated and > the CRC is still be stripped in following cases: > 1. For HIP08 hardware, the packet type is TCP and the length >is less than or equal to 60B. > 2. For other ha