Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2022-02-11 Thread Ferruh Yigit
On 2/11/2022 2:20 AM, Huichao Cai wrote: A small problem.Why is the content of the email just sent to you not visible at Patchwork (this patch). Hi Huichao, The discussion is not in the same email thread, it looks like it spread into multiple threads. This is because some email headers (Ref

Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2022-02-10 Thread Ananyev, Konstantin
> > According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the > fragmenting process.Add s

Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2021-12-02 Thread Dariusz Sosnowski
Hi, On Thu, 2 Dec 2021 10:24:40 +0800, Huichao Cai wrote: > > Substituting options with NOOP might cause rte_ipv4_fragment_packet to > > produce more fragments than necessary, since options with copied flag unset > > will still occupy space in IPv4 header. > --The "ip_options_fragment" just make

Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2021-12-01 Thread Dariusz Sosnowski
On Wed, 24 Nov 2021 16:47:06 +0800, Huichao Cai wrote: > +/* > + * Options "fragmenting", just fill options not > + * allowed in fragments with NOOPs. > + * Simple and stupid 8), but the most efficient way. > + */ > +static inline void ip_options_fragment(struct rte_ipv4_hdr *iph) > +{