Re: [PATCH] graph: fix node shrink

On Thu, Jan 19, 2023 at 11:32 AM David Marchand wrote: > > If the node id check failed, graph_lock was not taken before releasing. > > Fixes: c59dac2ca14a ("graph: implement node operations") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > If the node id check failed, graph_lock was no

Re: [PATCH] graph: fix node shrink

On Mon, Jan 23, 2023 at 2:33 PM Jerin Jacob wrote: > > On Thu, Jan 19, 2023 at 4:02 PM David Marchand > wrote: > > > > If the node id check failed, graph_lock was not taken before releasing. > > Thanks for the fix. > > > Why not this oneline fix? > > [main][dpdk.org] $ git diff > diff --git a/lib

Re: [PATCH] graph: fix node shrink

On Mon, Jan 23, 2023 at 7:21 PM David Marchand wrote: > > On Mon, Jan 23, 2023 at 2:33 PM Jerin Jacob wrote: > > > > On Thu, Jan 19, 2023 at 4:02 PM David Marchand > > wrote: > > > > > > If the node id check failed, graph_lock was not taken before releasing. > > > > Thanks for the fix. > > > > >

Re: [PATCH] graph: fix node shrink

On Thu, Jan 19, 2023 at 4:02 PM David Marchand wrote: > > If the node id check failed, graph_lock was not taken before releasing. Thanks for the fix. Why not this oneline fix? [main][dpdk.org] $ git diff diff --git a/lib/graph/node.c b/lib/graph/node.c index fc6345de07..89cdcf0207 100644 --- a