RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-16 Thread Dumitrescu, Cristian
e > ; jer...@marvell.com; techbo...@dpdk.org; > Mcnamara, John ; Zhang, Helin > ; dev@dpdk.org > Subject: Re: [PATCH] ethdev: introduce generic flow item and action > > On 8/16/2023 3:20 PM, Morten Brørup wrote: > >> From: Dumitrescu, Cristian [mailto:cristian.dumitre

Re: [PATCH] ethdev: introduce generic flow item and action

2023-08-16 Thread Ferruh Yigit
On 8/16/2023 3:20 PM, Morten Brørup wrote: >> From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] >> Sent: Wednesday, 16 August 2023 15.23 >> >> Hi Morten, >> >> >> > > In order to avoid conflicts between P4 and non-P4 generic flow items/actions, > the generic type s

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-16 Thread Morten Brørup
> From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Wednesday, 16 August 2023 15.23 > > Hi Morten, > > > > > > > > > > > In order to avoid conflicts between P4 and non-P4 generic flow > > > items/actions, > > > > the generic type should include information about how to i

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-16 Thread Dumitrescu, Cristian
Hi Morten, > > > > > > In order to avoid conflicts between P4 and non-P4 generic flow > > items/actions, > > > the generic type should include information about how to interpret the > > > information, which is why I suggest making it a Vendor-Specific type, with > > > vendor-specific TLV's (mana

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-16 Thread Dumitrescu, Cristian
Hi Ori, > > > Can you show me what items/actions are missing in rte_flow? > > > > The number of flow items (protocol headers, but also metadata) and flow > > actions > > that users can define in their P4 programs is infinite, so unfortunately > > Ori, as > > much > > as I want to grant you this

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-03 Thread Morten Brørup
> From: Zhang, Qi Z [mailto:qi.z.zh...@intel.com] > Sent: Thursday, 3 August 2023 03.05 > > > From: Morten Brørup > > Sent: Thursday, August 3, 2023 1:56 AM > > > > > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > > > Sent: Wednesday, 2 August 2023 19.23 > > > > > > > From: O

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-03 Thread Ori Kam
Cristian > > ; Jerin Jacob > > Cc: Zhang, Qi Z ; NBU-Contact-Thomas Monjalon > > (EXTERNAL) ; david.march...@redhat.com; > > Richardson, Bruce ; jer...@marvell.com; > > ferruh.yi...@amd.com; techbo...@dpdk.org; Mcnamara, John > > ; Zhang, Helin ; > >

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Zhang, Qi Z
marvell.com; > ferruh.yi...@amd.com; techbo...@dpdk.org; Mcnamara, John > ; Zhang, Helin ; > dev@dpdk.org > Subject: RE: [PATCH] ethdev: introduce generic flow item and action > > > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > > Sent: Wednesday, 2 Au

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Morten Brørup
> From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Wednesday, 2 August 2023 19.23 > > > From: Ori Kam > > Sent: Wednesday, August 2, 2023 5:06 PM > > > > Hi Qi, > > > > In addition to my previous email, > > I fully support you’re your idea to update the rte_flow API > > s

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Dumitrescu, Cristian
Bruce ; jer...@marvell.com; > ferruh.yi...@amd.com; techbo...@dpdk.org; Mcnamara, John > ; Zhang, Helin ; > dev@dpdk.org > Subject: RE: [PATCH] ethdev: introduce generic flow item and action > > Hi Qi, > > In addition to my previous email, > I fully support you’re your idea

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Dumitrescu, Cristian
marvell.com; > ferruh.yi...@amd.com; techbo...@dpdk.org; Mcnamara, John > ; Zhang, Helin ; > dev@dpdk.org > Subject: RE: [PATCH] ethdev: introduce generic flow item and action > > Hi Qi Hi Ori, Thanks for your input! > > > -Original Message- > > From: M

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Dumitrescu, Cristian
om; ferruh.yi...@amd.com; > techbo...@dpdk.org; Mcnamara, John ; Zhang, > Helin ; dev@dpdk.org > Subject: RE: [PATCH] ethdev: introduce generic flow item and action > > > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > > Sent: Wednesday, 2 August 2023 16.06 &g

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Ori Kam
Hi Qi, In addition to my previous email, I fully support you’re your idea to update the rte_flow API so it will be easier for P4 integration, I just think the suggested approach is not the correct one at least not as appears in the RFC. I think it will be good if we can discuss some uses cases

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Ori Kam
Hi Qi > -Original Message- > From: Morten Brørup > Sent: Wednesday, August 2, 2023 6:25 PM > > > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > > Sent: Wednesday, 2 August 2023 16.06 > > > > > From: Jerin Jacob > > > Sent: Wednesday, August 2, 2023 12:22 PM > > > >

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Morten Brørup
> From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Wednesday, 2 August 2023 16.06 > > > From: Jerin Jacob > > Sent: Wednesday, August 2, 2023 12:22 PM > > > > On Wed, Aug 2, 2023 at 4:31 PM Morten Brørup > > wrote: > > > > > > > From: Morten Brørup [mailto:m...@smartshar

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Morten Brørup
> From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Wednesday, 2 August 2023 16.06 > > Hi Morten, > > Thanks for your reply, comments inline below. > > > From: Morten Brørup > > Sent: Wednesday, August 2, 2023 11:25 AM > > > > > From: Qi Zhang [mailto:qi.z.zh...@intel.co

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Dumitrescu, Cristian
bo...@dpdk.org; Mcnamara, John ; Zhang, > Helin ; dev@dpdk.org; Dumitrescu, Cristian > > Subject: Re: [PATCH] ethdev: introduce generic flow item and action > > On Wed, Aug 2, 2023 at 4:31 PM Morten Brørup > wrote: > > > > > From: Morten Brørup [mailto:m...@sm

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Dumitrescu, Cristian
ell.com; ferruh.yi...@amd.com > Cc: cristian.dumiter...@intel.com; techbo...@dpdk.org; Mcnamara, John > ; Zhang, Helin ; > dev@dpdk.org; Dumitrescu, Cristian > Subject: RE: [PATCH] ethdev: introduce generic flow item and action > > > From: Qi Zhang [mailto:qi.z.zh...@intel.com] &

Re: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Jerin Jacob
On Wed, Aug 2, 2023 at 4:31 PM Morten Brørup wrote: > > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > Sent: Wednesday, 2 August 2023 12.25 > > > > > From: Qi Zhang [mailto:qi.z.zh...@intel.com] > > > Sent: Wednesday, 2 August 2023 19.35 > > > > > > From: Cristian Dumitrescu > > >

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Wednesday, 2 August 2023 12.25 > > > From: Qi Zhang [mailto:qi.z.zh...@intel.com] > > Sent: Wednesday, 2 August 2023 19.35 > > > > From: Cristian Dumitrescu > > > > For network devices that are programmable through languages such a

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Morten Brørup
> From: Qi Zhang [mailto:qi.z.zh...@intel.com] > Sent: Wednesday, 2 August 2023 19.35 > > From: Cristian Dumitrescu > > For network devices that are programmable through languages such as > the P4 language, there are no pre-defined flow items and actions. > > The format of the protocol header a

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, August 3, 2023 1:35 AM > To: tho...@monjalon.net; or...@nvidia.com; david.march...@redhat.com; > Richardson, Bruce ; jer...@marvell.com; > ferruh.yi...@amd.com > Cc: cristian.dumiter...@intel.com; techbo...@dpdk.org; Mcnamara, J